Re-implement row selection #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Oct 2, 2019
nstepien
approved these changes
Oct 4, 2019
12 tasks
qili26
reviewed
Oct 4, 2019
| rowHeight={50} | ||
| minHeight={600} | ||
| selectedRows={this.state.selectedRows} | ||
| onSelectedRowsChange={this.onSelectedRowsChange} |
There was a problem hiding this comment.
This is a new API. We should mark it and add docs later.
nstepien
pushed a commit
that referenced
this pull request
Oct 7, 2019
* Re-implement row selection * Re-enable jsx-curly-brace-presence * onSelectedRowsChanged -> onSelectedRowsChange * Small cleanup in Canvas.tsx * small tweaks * Delete RowUtils tests * Fix Canvas tests * Get shift selection almost working * Simplify a few exports * Focus CellMask when clicking on a cell * Working shift selection * use a ref for lastSelectedRowIdx * Add class methods to avoid recomputation * Do it the react way * Simplify 1 type * Fix selection * tweaks * Remove references to `enableRowSelect` * More cleanup * fix some tests * fix tests * Remove @testing-library/react/cleanup-after-each * Fix some examples * Fix another example * optimize all-features example * Cleanup viewport events * Cleanup props, remove PureComponent * Fix draggable header example * Commit reordering fixes (not working) * Remove row-reordering components * Fix eslint errors * Remove re-ordering refrences * Remove tests for the deleted file * Fix types
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] Fir row draggingRemove re-ordering example and re-implement if needed