Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent extract_metadata from failing then @type is an empty list. #303

Conversation

edkrueger
Copy link
Contributor

Let me know if you'd like me to make any changes!

…d realworld test and associated html doc in tests/cache, add mocked up test to json tests. Fixes adbar#299.
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #303 (5c439c4) into master (6d8fb8d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   96.01%   96.04%   +0.03%     
==========================================
  Files          21       21              
  Lines        3240     3240              
==========================================
+ Hits         3111     3112       +1     
+ Misses        129      128       -1     
Impacted Files Coverage Δ
trafilatura/json_metadata.py 96.55% <100.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adbar
Copy link
Owner

adbar commented Feb 20, 2023

Perfect, thanks!

@adbar adbar merged commit 5a30b26 into adbar:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty list value for @type causes extract_metadata to fail
3 participants