feat: extract pagetype from og:type or ld+json #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #307
element_text
was coming with bad html formatting causing error and having to useextract_json_parse_error
. This patch fix the problem withhtml.unescape()
OBS: I realized that json_metadata already had some
@type
implementations but I preferred not to change it to prevent break anything and implemented it with new conditions and lists (not sure if this is the ideal approach)OBS2: I think txttocsv function and test_txttocsv should be refactored. Every minor change in metadata breaks the test.
OBS3: extract_meta_json function could be simplified and refactored
OBS4: Only returns pagetype from ld+json if the page is some kind of an article/category/home/site/bloc etc... got types from https://schema.org/docs/full.html