Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraction: improve justext fallback #652

Merged
merged 7 commits into from
Jul 23, 2024
Merged

extraction: improve justext fallback #652

merged 7 commits into from
Jul 23, 2024

Conversation

adbar
Copy link
Owner

@adbar adbar commented Jul 19, 2024

  • Better performance for underlying justext library
  • Generate justext stoplist through lazy loading, addresses Why lzma for data compression? #559 by removing the corresponding LZMA pickled data.

@adbar adbar marked this pull request as draft July 19, 2024 15:33
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (7e51a4e) to head (d7a74b2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   97.94%   97.97%   +0.02%     
==========================================
  Files          21       21              
  Lines        3506     3502       -4     
==========================================
- Hits         3434     3431       -3     
+ Misses         72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar adbar marked this pull request as ready for review July 23, 2024 16:12
@adbar adbar merged commit 0c44b71 into master Jul 23, 2024
13 checks passed
@adbar adbar deleted the improve_justext branch July 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant