Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always crash if can't resolve metadata #31

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

garronej
Copy link
Contributor

Hello @adbayb,

termost tries to automatically resolve the name, version and description even when explicitely provided.
This makes the Termost was unable to retrieve automatically the package name and version. To fix it, use termost({ name, description, version }) to define them manually. error unavoidable.

This PR fixes that.

Copy link

changeset-bot bot commented May 19, 2024

🦋 Changeset detected

Latest commit: 0a9e201

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
termost Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

garronej added a commit to keycloakify/keycloakify that referenced this pull request May 19, 2024
@adbayb
Copy link
Owner

adbayb commented Jun 17, 2024

Thanks for the fix @garronej.

Two small feedbacks before merging:

  • Could you please commit a changeset file (patch describing the change)? The root command pnpm release:log will launch the needed prompt.
  • If you can/have time, adding a test can be useful to make the fix sustainable over time 😄 .

@garronej
Copy link
Contributor Author

garronej commented Jun 17, 2024

Hello @adbayb,
I rebased with the changeset.
Regarding the test, I'll leave it to you. This PR does not introduce a new feature it's a bug fix.

By the way Keycloakify 10 is about to release and it's using termost.
keycloakify/keycloakify#538
So a lot of pepole are going to be using it 🎉

Copy link
Owner

@adbayb adbayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. A release will be done right after the merge.
I'll add a test later 👍 .

@adbayb adbayb merged commit 84ce62c into adbayb:main Jun 17, 2024
@adbayb
Copy link
Owner

adbayb commented Jun 17, 2024

@garronej Release available v0.12.1.

@garronej garronej deleted the fix_metadata_resolution branch June 19, 2024 01:50
garronej added a commit to keycloakify/keycloakify that referenced this pull request Jun 19, 2024
@garronej
Copy link
Contributor Author

Nice, thank you!
This allowed me to remove the build step to apply my patch: keycloakify/keycloakify@96b6270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants