-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always crash if can't resolve metadata #31
Conversation
🦋 Changeset detectedLatest commit: 0a9e201 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3821886
to
0a9e201
Compare
Hello @adbayb, By the way Keycloakify 10 is about to release and it's using termost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. A release will be done right after the merge.
I'll add a test later 👍 .
Nice, thank you! |
Hello @adbayb,
termost tries to automatically resolve the
name
,version
anddescription
even when explicitely provided.This makes the
Termost was unable to retrieve automatically the package name and version. To fix it, use
termost({ name, description, version })to define them manually.
error unavoidable.This PR fixes that.