Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors: add new function chooseHigherContrast #2741

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

mrtnzlml
Copy link
Member

No description provided.

Copy link
Contributor

@michalsanger michalsanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to support alpha channel:
http://marcodiiga.github.io/rgba-to-rgb-conversion

@mrtnzlml mrtnzlml force-pushed the colors_add_chooseHigherContrast branch from 5fb300e to 87cda1a Compare July 15, 2021 18:24
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website July 15, 2021 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-example-relay July 15, 2021 18:24 Inactive
@mrtnzlml mrtnzlml force-pushed the colors_add_chooseHigherContrast branch from 87cda1a to 721fb42 Compare July 15, 2021 20:37
@vercel vercel bot temporarily deployed to Preview – universe-example-relay July 15, 2021 20:37 Inactive
@vercel vercel bot temporarily deployed to Preview – universe-sx-tailwind-website July 15, 2021 20:37 Inactive
@mrtnzlml
Copy link
Member Author

Would be great to support alpha channel:
http://marcodiiga.github.io/rgba-to-rgb-conversion

This is cool. The missing alpha channel is something I'd like to change for sure. It is a design mistake of this package that it uses RGB triplet [r, g, b] and it ignores alpha values. 🙈 Let's stick with it for now, but I am already thinking about how to refactor it.

@kodiakhq kodiakhq bot merged commit 09b465d into master Jul 15, 2021
@kodiakhq kodiakhq bot deleted the colors_add_chooseHigherContrast branch July 15, 2021 20:45
@mrtnzlml mrtnzlml mentioned this pull request Aug 6, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants