Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current room populates in Sharing menu when ID > 09h #67

Closed
adelyte-austin opened this issue Apr 26, 2017 · 4 comments
Closed

Current room populates in Sharing menu when ID > 09h #67

adelyte-austin opened this issue Apr 26, 2017 · 4 comments
Assignees
Labels

Comments

@adelyte-austin
Copy link
Member

Reference #36 and #38 for historical cases of handling IDs higher than 09h.

@adelyte-austin
Copy link
Member Author

issue67

@adelyte-chris
Copy link
Member

adelyte-chris commented Apr 27, 2017 via email

@adelyte-austin
Copy link
Member Author

The current room should not be visible in the Sharing Menu

@adelyte-chris
Copy link
Member

All comparisons have to be done on the ID or index on both sides of the comparison. The offending code is an incompatibility between lines 756 and 813.

I would suggest changing it as follows:

FUNCTION UpdateShareVisible(INTEGER room)
{
    /* ... */
    IF(room = IdToIndex(Room_Is))
    {
        Share_Visible[share] = 0;
    }
    /* ... */
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants