Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

People Details cosmetics #441

Open
tinne opened this issue Nov 6, 2020 · 2 comments · May be fixed by #451
Open

People Details cosmetics #441

tinne opened this issue Nov 6, 2020 · 2 comments · May be fixed by #451
Assignees
@FrederikSchlemmer
Labels
question state: has PR

Comments

@tinne
Copy link
Member

tinne commented Nov 6, 2020 •
edited
Loading

The following changes should be applied to the People detail view:

  • Highlights should have the default daily rate added, with a localized label denoting the null value (not set).
  • First booked and Last booked should have four digit years.
  • The currency signs in avg. daily rate and budget burned must be removed. They should be removed of configuration added to the project settings.
@FrederikSchlemmer FrederikSchlemmer self-assigned this Nov 23, 2020
@FrederikSchlemmer
Copy link
Collaborator

FrederikSchlemmer commented Nov 24, 2020 •
edited
Loading

The following changes should be applied to the People detail view:

  • The currency signs in avg. daily rate and budget burned might be hardcoded. They should be removed of configuration added to the project settings.

We should extract this into another issue because the currency needs to be adapted in the whole project.
The used currency signs are not hardcoded and will adopt to changed locales.

@FrederikSchlemmer FrederikSchlemmer mentioned this issue Nov 24, 2020
Closed
@FrederikSchlemmer FrederikSchlemmer linked a pull request Nov 24, 2020 that will close this issue
person-details: Adds defaultDailyRate and minor design changes #446
Closed
@tinne tinne mentioned this issue Dec 7, 2020
Open
@tinne
Copy link
Member Author

tinne commented Dec 7, 2020

i18n and l10n moved to #448

@FrederikSchlemmer FrederikSchlemmer linked a pull request Dec 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederikSchlemmer FrederikSchlemmer

Labels
question state: has PR
Projects
None yet
Milestone
No milestone
3 participants
@tinne @FrederikSchlemmer @czarnecki