person-details: Adds defaultDailyRate and minor design changes #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinne
requested changes
Dec 7, 2020
There was a problem hiding this comment.
It is about time you use a real database. Here goes the usual Group-by-fix to your adjusted query:
Fix_query_in_order_to_work_with_Oracle_DB_.patch
Apart from that, a very minor issue: The button Month report is missing the usual trailing space behind “Report of budget burned by this person aggregated by month”, glueing the arrow icon to the text.
FrederikSchlemmer
force-pushed
the
design-person-details-page
branch
from
0df1e3c
to
a774838
Compare
The defaultDailyRate is added to the highlights displayed on the person details page. Additionally the formatting of the date has been changed.
FrederikSchlemmer
force-pushed
the
design-person-details-page
branch
from
a774838
to
9b0a78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the style of the person details page. The person highlights now include the defaultDailyRate and the year of the dates are displayed with four digits.
Note: This Pull Request is based on #413, so first the PR #413 must be merged and then a rebase is necessary.
Closes #441