pkg: simplify network setup and avoid listening on all interfaces #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroimartin
force-pushed
the
poc-network
branch
from
93c395c
to
999432b
Compare
jroimartin
force-pushed
the
poc-network
branch
5 times, most recently
from
a7f0814
to
d291800
Compare
The current implementation does not take into account the current Docker context. This commit updates vulcan-local to mimic the behavior of the Docker CLI.
jroimartin
force-pushed
the
poc-network
branch
4 times, most recently
from
c579f15
to
ba529e1
Compare
jroimartin
force-pushed
the
poc-network
branch
from
47a7b3d
to
f1b6b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This POC is a playground to find a solution compatible with both Linux and macOS that avoids services to listen on all interfaces.
It depends on the following vulcan-agent PR:
It modifies go.mod to require
github.com/adevinta/vulcan-agent@agent-listenerfor testing purposes. But, of course, if this POC was accepted at any point, go.mod should be changed to require a stable vulcan-agent version that includes the mentioned PR.Run the following command to test this PR: