Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): make sure to call the super functions on treeFor methods #1048

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

anehx
Copy link
Member

@anehx anehx commented Apr 17, 2023

No description provided.

@anehx anehx requested review from czosel and derrabauke April 17, 2023 10:01
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@czosel czosel merged commit 015ce0b into adfinis:main Apr 17, 2023
@anehx
Copy link
Member Author

anehx commented Apr 17, 2023

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@anehx anehx added the released label Apr 17, 2023
czosel added a commit that referenced this pull request Apr 18, 2023
This fixes an issue introduced in #1048 where the ember-uikit styles are
only available for the build of the host app, but not for addons which
also use ember-uikit (e.g.
projectcaluma/ember-caluma#2378).
czosel added a commit that referenced this pull request Apr 18, 2023
This fixes an issue introduced in #1048 where the ember-uikit styles are
only available for the build of the host app, but not for addons which
also use ember-uikit (e.g.
projectcaluma/ember-caluma#2378).
anehx pushed a commit that referenced this pull request Apr 18, 2023
## [7.0.3](v7.0.2...v7.0.3) (2023-04-18)

### Bug Fixes

* **build:** generate app tree before merging ([dddec06](dddec06)), closes [#1048](#1048)
@anehx anehx deleted the build-fix branch April 26, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants