Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(app-of-apps): add info on app-of-apps chart structure #499

Merged
merged 7 commits into from
Jan 10, 2022
Merged

docs(app-of-apps): add info on app-of-apps chart structure #499

merged 7 commits into from
Jan 10, 2022

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Dec 24, 2021 •
edited
Loading

Description

Add a section that explains how app-of-apps charts are structured.

Issues

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 24, 2021
@hairmare hairmare marked this pull request as ready for review December 24, 2021 09:51
@hairmare hairmare requested a review from a team as a code owner December 24, 2021 09:51
@hairmare hairmare requested review from tongpu and isantospardo and removed request for a team December 24, 2021 09:51
@hairmare hairmare mentioned this pull request Dec 24, 2021
Open
9 tasks
@hairmare hairmare mentioned this pull request Jan 3, 2022
Merged
6 tasks
isantospardo
isantospardo approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@isantospardo isantospardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairmare hairmare enabled auto-merge (squash) January 10, 2022 10:31
@hairmare hairmare merged commit d6baba5 into adfinis:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inisitijitty inisitijitty inisitijitty left review comments

@isantospardo isantospardo isantospardo approved these changes

@tongpu tongpu Awaiting requested review from tongpu tongpu was automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hairmare @inisitijitty @isantospardo