Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

feat: remaining effort #770

Merged
merged 33 commits into from
Jan 23, 2023
Merged

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke self-assigned this Jan 5, 2023
@derrabauke derrabauke marked this pull request as ready for review January 17, 2023 15:52
@derrabauke
Copy link
Contributor Author

@czosel Not sure what to do about the codecov outcomes. The -0.39% is almost nothing. Any proposals for improvements?

@derrabauke derrabauke removed the request for review from czosel January 18, 2023 13:58
The regular set is thinner in comparison to the solid set, which
is closer to the previously used icon set. Therefore we have to
add the special prefix to icons which are not available in the
regular icon set but which are already used in the app.
app/components/filter-sidebar/group/template.hbs Outdated Show resolved Hide resolved
app/models/customer-statistic.js Outdated Show resolved Hide resolved
app/models/overtime-credit.js Show resolved Hide resolved
app/models/report.js Show resolved Hide resolved
app/users/edit/credits/index/template.hbs Outdated Show resolved Hide resolved
ember-cli-build.js Outdated Show resolved Hide resolved
vendor/adcssy.css Outdated Show resolved Hide resolved
app/components/statistic-list/template.hbs Outdated Show resolved Hide resolved
app/components/sy-durationpicker/component.js Outdated Show resolved Hide resolved
app/components/progress-tooltip/component.js Outdated Show resolved Hide resolved
app/components/progress-tooltip/component.js Outdated Show resolved Hide resolved
app/components/report-row/template.hbs Outdated Show resolved Hide resolved
vendor/adcssy.css Outdated Show resolved Hide resolved
app/components/report-row/template.hbs Outdated Show resolved Hide resolved
app/projects/controller.js Outdated Show resolved Hide resolved
app/styles/variables.scss Outdated Show resolved Hide resolved
app/styles/components/sy-checkbox.scss Show resolved Hide resolved
app/users/edit/credits/index/template.hbs Outdated Show resolved Hide resolved
app/users/edit/credits/index/template.hbs Show resolved Hide resolved
Copy link
Contributor

@velrest velrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet thanks!

@velrest
Copy link
Contributor

velrest commented Jan 20, 2023

Possible followups for this PR:

  • Clean up scss adcssy styling
  • Remove comment strings to reduce code base

@derrabauke derrabauke merged commit 06c8a8a into adfinis:master Jan 23, 2023
@derrabauke derrabauke deleted the feat-remaining-effort branch January 23, 2023 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants