This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabauke
force-pushed
the
feat-remaining-effort
branch
from
January 11, 2023 13:53
c0f0631
to
2ba694f
Compare
This fixes the include parameter for the statistics endpoint according to the fix merged into the backend with: adfinis/timed-backend#918
derrabauke
force-pushed
the
feat-remaining-effort
branch
from
January 17, 2023 10:07
5b2d0f1
to
1d480ce
Compare
@czosel Not sure what to do about the codecov outcomes. The -0.39% is almost nothing. Any proposals for improvements? |
The regular set is thinner in comparison to the solid set, which is closer to the previously used icon set. Therefore we have to add the special prefix to icons which are not available in the regular icon set but which are already used in the app.
derrabauke
force-pushed
the
feat-remaining-effort
branch
from
January 18, 2023 14:18
a3bbe8c
to
28c8788
Compare
Merged
velrest
reviewed
Jan 18, 2023
derrabauke
force-pushed
the
feat-remaining-effort
branch
from
January 19, 2023 09:51
600d50a
to
ac9d2da
Compare
* additionally fix test assertion after layout simplification
derrabauke
force-pushed
the
feat-remaining-effort
branch
from
January 19, 2023 17:55
3942817
to
ec0c669
Compare
velrest
reviewed
Jan 20, 2023
velrest
reviewed
Jan 20, 2023
* optional on click handler respecting disabled state * improve hint for disabled state
velrest
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks!
Possible followups for this PR:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#721 in harmony with adfinis/timed-backend#874