Tigase stanza error

[pmashchak]

It quick and a bit dirty fix, but hope this will help fix the problem.
Tigase is really wide used XMPP server and I think you should not miss opportunity to support it also.
The problem was here with priority of child nodes in <stream:features stanza>
It was looking like this:

<features>
    <ver xmlns="urn:xmpp:features:rosterver"/>
    <session xmlns="urn:ietf:params:xml:ns:xmpp-session"/>
    <bind xmlns="urn:ietf:params:xml:ns:xmpp-bind"/>
 </features>

Tigase can't create session before binding.
I solve this problem by sorting child nodes to move <bind/> before <session/> request.
Maybe this is not the best way, but we found a root of the problem.

[arthef]

It's not that Tigase can't create session before bindings. The spec says that the session is created after the resource bind, and Tigase just follows the spec. Besides, the session feature has been deprecated and removed from the last spec. Tigase only offers it for backward compatibility as lots of clients are not updated and require it.
The order of elements within features element is not important, the spec says, so the client, not the server should be fixed to follow the spec.

[benlangfeld]

Could you trim this down to only the relevant commit (on a feature branch) with some specs?

[tomquas]

blather-0.8.4 still/again has issues with connection to Tigase. pavlo's patch 25a12da somehow got lost. could you please add a regression to ensure the bind-before-session request scheme works? thx

[benlangfeld]

A pull request would be lovely :)

[tomquas]

not sure i understand. pull request #95 exists, what is it you want me to do?

[benlangfeld]

You say it's regressed due to a lack of test coverage...

[tomquas]

right. can you tell me what your plans are for this pull request? it contains the fix plus lots of other stuff. should i extract that patch, add a test, and open a new pull request?

[benlangfeld]

Ah, I see, apologies, I failed to fully check on the status of this.

Yeah, this can't be merged until specs are added and only the relevant commits are included. It seems @arturhefczyc simply disappeared, and this was never merged. I don't use Tigase, so I can't justify working on this myself. Contributions from those who care are welcome, but they have to meet a certain standard to be included.

[tomquas]

ok. i isolated the fix and added a test. however, i can't make the test run through, it keeps hanging somewhere in the mock server. can you help? https://gist.github.com/5680241

[arthef]

Ben,

What you mean by "arturhefczyc simply disappeared"? ;-)
I am still there, somewhere. I am just involved in a different project.
To be honest I do not know why I am a part of the discussion, I can't remember being
involved in the project.

Artur

On May 30, 2013, at 7:58 AM, Ben Langfeld notifications@github.com wrote:

Ah, I see, apologies, I failed to fully check on the status of this.

Yeah, this can't be merged until specs are added and only the relevant commits are included. It seems @arturhefczyc simply disappeared, and this was never merged. I don't use Tigase, so I can't justify working on this myself. Contributions from those who care are welcome, but they have to meet a certain standard to be included.

—
Reply to this email directly or view it on GitHub.

[benlangfeld]

This was your pull request, and it was never completed, which is the
reason it was not merged :)

[benlangfeld]

@arturhefczyc Yet again, I make a boob. Sincerest apologies, this PR was originally submitted by @pmashchak.

@tomquas got some specs in for this and submitted #112, which has now been merged. I'm doing a little bit of cleanup and will get 0.8.5 out shortly. Thanks everyone, and apologies again for my lack of close attention.

I'm going to have to quit iPhone PR review.