fix quarter precision with one month has 31 days #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for PR. for some reason this has caused infinite loop in my local 💫 😵 and it seems same happen in actions too https://github.com/adhocore/gronx/actions/runs/5035233909 |
I don't think we can fix the last day of qurater issue by the simple change... |
adhocore
reviewed
May 21, 2023
| @@ -46,7 +46,8 @@ func loop(gron Gronx, segments []string, start time.Time, incl bool, reverse boo | |||
| for iter > 0 { | |||
There was a problem hiding this comment.
over:
for iter > 0 {
iter--@icoreman infinite loop can be prevented by moving over label outside loop
|
closing as the scope quickly escalates if we attempt to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #26
Fix way: reverse loop i.e from last (len-1) segment to first (0) segment in here)