This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Add support for Ledger Hardware Wallet #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(keys): rename `Keys` to `InMemoryKeys` refactor(keys): impl above traits for `InMemoryKeys` refactor(lightwallet): split methods between generic over keystore and `InMemoryKeys` specific style: formatting
feat(builder): impl `Builder` for zcash-primitive's Builder feat(keystore): obtain associated builder for certain keystore refactor: use new `Builder` trait
Modularize keystore functionality
feat(txbuilder): add `HsmTxProver` support
feat(keys:ledger): initial impl of `Builder` and `Keystore`
misc: add compute_taddr utility misc: add some derives and remove some unnecessary code (spurious clones)
feat(ledger): add utility functions feat(keystores): add enum to wrap keystore variants
refactor: use new `Keystores` enum API - WIP
refactor: use keystores instead of requiring in memory keystore where possible
feat(leger): `add_zaddr` and `add_taddr` with automatic path creation refactor(lightwallet): provide defaults for some fields tin non-memory keystore
feat(wallet): add support for more functionality with both keystores refactor: specify if a clone of the keystore is necessary
…ght-cli into feat/hsm+cli
Integrate Ledger based keystore with lib and CLI
feat(ledger): device ""id"" refactor(keys:adapters): use `Self` instead of enum name chore: bump wallet serialization version
refactor: adjust spendable notes based on ivk only feat(keystores): method to retrieve all spendable ivks refactor(wallet): initialize `Keystores` from file
refactor: don't force memory keys for lock/unlock encrypt/decrypt operations
refactor(data): use ivk in SaplingNoteData instead of extfvk, refactor(data): also for SpendableNotes refactor(sync): compute nullifier via keystore refactor(sync): use ivk instead of extfvk refactor(builder): use ivk instead of vk for adding sapling spends misc: use `to_repr()` to compare ivks
Complete ledger integration
|
Thanks for this. Reviewing it... |
|
Hey @adityapk00, were you able to check this PR? Do you have any comment or improvement that we should make? |
|
@adityapk00, what help would be needed to progress this PR? |
fix(ledger): missing txversion on build
Add support for TX v5 to Ledger
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the work that we have done to add hardware wallet support (via Ledger device) to the lib (and cli).
We also have another branch
ledger-mergedwhere there are some cherry picked commits to allow the testing and live demo we presented at ZCON3, but it would make the history messy so we made a PR with just our commits