Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Data Quality #262

Closed
8 tasks
dwalt opened this issue Mar 1, 2023 · 6 comments · Fixed by #269
Closed
8 tasks

Feature/Data Quality #262

dwalt opened this issue Mar 1, 2023 · 6 comments · Fixed by #269
Assignees

Comments

@dwalt
Copy link
Collaborator

dwalt commented Mar 1, 2023

  • Missing asterisks for required elements - review schema issues
  • Missing element definitions - review schema issues
  • Order of Report elements should follow that outlined in Report schema issue New Class - Report #224
  • Evaluation Method is not an array
  • Quality Measure: either a name or identifier are required
  • Translator UI not working, network error
  • Type element is missing, required to identify the standard report (see issue New Class - Report #224)
  • Scope is required, max of one
@jwaspin
Copy link
Contributor

jwaspin commented Jul 17, 2023

Was PR #261 sufficient to close this?

--Update: No, PR #261 does not solve these issues

This was referenced Jul 17, 2023
@jwaspin
Copy link
Contributor

jwaspin commented Dec 20, 2023

@dwalt

The following will be fixed in PR #269

  • Order of Report elements
  • Evaluation Method is not an array

Actually, all of the issues in the original description will be resolved in the PR, not just these 2

@jwaspin jwaspin self-assigned this Dec 21, 2023
@jwaspin
Copy link
Contributor

jwaspin commented Dec 21, 2023

@dwalt

Translator UI not working, network error does not seem to be related to mdJson-schemas, should this be in here?

Scope is required Does this apply to everywhere scope exists within data quality? (based on them all being single objects and not an array, they are all already limited to only one, but none of the schemas indicate the scope is required)

@jwaspin
Copy link
Contributor

jwaspin commented Dec 21, 2023

What I've done: (changes exist in PR #269 )

  • Missing asterisks for required elements - review schema issues
  • Missing element definitions - review schema issues
  • Order of Report elements should follow that outlined in Report schema issue New Class - Report #224
  • Evaluation Method is not an array
  • Quality Measure: either a name or identifier are required
  • Translator UI not working, network error
  • Type element is missing, required to identify the standard report (see issue New Class - Report #224)
  • Scope is required, max of one

@jwaspin
Copy link
Contributor

jwaspin commented Jan 18, 2024

It mentions "Translator UI not working, network error" but I'm not sure what this refers to. If I were to guess, this is actually an issue in mdTools, not mdJson-schemas, because that translator UI is not working, but there's already an issue for that in the mdTools repository.

@dwalt
Copy link
Collaborator Author

dwalt commented Jan 18, 2024

@jwaspin I would agree, I believe this was an artifact of previous Data Quality testing identifying that translation of DQ could not be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants