Review and update adiwg_dataQualityElement codelist

[hmaier-fws]

The following items are needed to fully close out #52

• Verify and add missing parent classes
  • Add DQ_ThematicAccuracy
  • Add DQ_Metaquality
• Update codelist descriptions to match those in the XSD
  • Update description of DQ_PositionalAccuracy
  • Update description of DQ_TemporalQuality
  • Update description of DQ_LogicalConsistency
• Verify use of DQ_CoverageResult class

Missing parent classes

The adiwg_dataQualityElement.yml codelist contains several parent (abstract) classes such as DQ_PositionalAccuracy (AbstractDQ_PositionalAccuracy) and DQ_Completeness (AbstractDQ_Completeness), hovever, the following parent classes are not included in the list:

DQ_ThematicAccuracy (AbstractDQ_ThematicAccuracy). Add:

codeName: DQ_ThematicAccuracy
description: "accuracy of quantitative attributes and the correctness of non-quantitative attributes and of the classifications of features and their relationships"

see: https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityElement.xsd

DQ_Metaquality (AbstractDQ_Metaquality). Add:

codeName: DQ_Metaquality
description: "accuracy of quantitative attributes and the correctness of non-quantitative attributes and of the classifications of features and their relationships"

See: https://standards.iso.org/iso/19157/-2/mdq/1.0/metaquality.xsd

Update codelist descriptions

The descriptions of several parent classes do not match those provided by the XSD (https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityElement.xsd).

• AbstractDQ_PositionalAccuracy = "accuracy of the position of features"
• AbstractDQ_TemporalQuality = "accuracy of the temporal attributes and temporal relationships of features"
• AbstractDQ_LogicalConsistency = "degree of adherence to logical rules of data structure, attribution and relationships (data structure can be conceptual, logical or physical)"

Update the descriptions for DQ_PositionalAccuracy, DQ_TemporalQuality, and DQ_LogicalConsistency to match the descriptions for the above abstract classes.

Verify use of DQ_CoverageResult

DQ_CoverageResult doesn't seem to be a valid class. Should this be QE_CoverageResult? See:

• https://wiki.esipfed.org/QE_CoverageResult
• https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityImagery.xsd

If so, change DQ_CoverageResult to:

codeName: QE_CoverageResult
description: "result of a data quality measure organising the measured values as a coverage"

[dwalt]

@hmaier-fws DQ_CoverageResult was a new sub-class of DQ_Result, added by the 19157 2018 amendment. "Result of a data quality measure organizing the measured values as a coverage". If you look at the diagram on the ESIP web page you will see that ESIP's name is inconsistent with the ISO documentation. Likewise, the definition is inconsistent with the ISO document.

[jwaspin]

@dwalt @hmaier-fws Hilmar, you are correct, the coverage result is not DQ_ it's QE_ so I will get that changed

[jwaspin]

@dwalt @hmaier-fws I just realized, Hilmar, it looks like you're referring to the DQ_Element list, which I do not see anything about coverage result at all. The result class itself is QE_ but if it's supposed to be part of the DQ_Element Types then I don't see where it was added.

[jwaspin]

@hmaier-fws We have DQ_Confidence listed as 006, which appears to be the actual name used for Metaquality if I understand correctly:
<element name="DQ_Confidence" substitutionGroup="mdq:AbstractDQ_Metaquality" type="mdq:DQ_Confidence_Type">
Do we still need DQ_Metaquality?

And for DQ_ThematicAccuracy I found this one:
<element name="DQ_NonQuantitativeAttributeCorrectness" substitutionGroup="mdq:AbstractDQ_ThematicAccuracy" type="mdq:DQ_NonQuantitativeAttributeCorrectness_Type">
which we also have in our list.

[dwalt]

@jwaspin @hmaier-fws Sorry for my earlier comment on DQ_Element, I confused it with evaluationMethod, I have deleted that comment.

Per earlier comment, CoverageResult is DQ_CoverageResult, according to the ISO 19157:2018 documentation. I don't know where ESIP got its information from.

DQ_Element parent classes are conceptual classes, therefore they were denormalized out. DQ_Metaquality is one such example. See adiwg/mdJson-schemas#224 for the definitive list.

[hmaier-fws]

Discussion issues resolved by about comments