Data Quality Code Lists #53
Conversation
Rename iso_dataQualityElement.yml to adiwg_dataQualityElement.yml. Fix codelistName, source, and sourceName.
Also add more units.
|
@hmaier-fws Just deployed the test container and updated the comment with the link |
|
@dwalt I'm responding here since the other PR was closed, but the changes can be viewed in the test instance. I will update 8050 again once this one is merged. |
There was a problem hiding this comment.
I don't think this closes #39, I believe that codelist is intended to populate a mdEditor pick as opposed to defining the actual ISO data quality class names. I've flagged that issue for discussion.
There was a problem hiding this comment.
List matches definitions as described in https://standards.iso.org/iso/19157/-2/dqm/1.0/codelists.xml
There was a problem hiding this comment.
Code names and descriptions match those described by https://standards.iso.org/iso/19157/-2/mdq/1.0/codelists.xml. Spelling of "data set" differs from ISO, which uses "dataset'.
The above codelist, and https://standards.iso.org/iso/19157/resources/Codelists/cat/codelists.xml, both provide a list definition of "description of the evaluation method and procedure applied". Our list description seems to be based on https://standards.iso.org/iso/19157/resources/Codelists/gml/DQ_EvaluationMethodTypeCode.xml which uses "type of method for evaluating an identified data quality measure".
I'll merge this file and have created #56 to address the outstanding issues.
There was a problem hiding this comment.
Seems to be missing something. I'll merge this file and have created #58 to discuss/address any outstanding issues.
DQ_IndirectEvaluation type is not listed. See:
- https://wiki.esipfed.org/DQ_IndirectEvaluation
- https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityEvaluation.xsd
- New Class - EvaluationMethod mdJson-schemas#226
The codeName: data evaluation method does not seem to be listed by ESIP or ISO. See:
- https://wiki.esipfed.org/DQ_EvaluationMethod
- https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityEvaluation.xsd
Is this supposed to correspond with "DQ_DataInspection"?
There was a problem hiding this comment.
Most codes match definitions provided by:
- https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityElement.xsd
- https://standards.iso.org/iso/19157/-2/mdq/1.0/metaquality.xsd
- https://standards.iso.org/iso/19157/-2/mdq/1.0/dataQualityImagery.xsd
but there seem to be several discrepancies. I'll merge this file and have created #57 to address the outstanding issues.
* Remove "geographic" from description (#54) * Remove "geographic" from description * Update iso_scope.yml Update definition from "a dataset" to "the dataset" to match the definition as defined in https://standards.iso.org/iso/19115/-3/mcc/1.0/codelists.xml. --------- Co-authored-by: Hilmar Maier <hilmar_maier@fws.gov> * Data Quality Code Lists (#53) * Fix Data Quality Element Rename iso_dataQualityElement.yml to adiwg_dataQualityElement.yml. Fix codelistName, source, and sourceName. * Add iso_valueStructure.yml * Add iso_evaluationMethodTypeCode * Add adiwg_evaluationMethod * Add iso_uom * Rename iso_uom to adiwg_unitsOfMeasure Also add more units. * Remove Comment * Update .gitignore --------- Co-authored-by: Johnathan <jwaspin@users.noreply.github.com>
Closes #37
Closes #38
Closes #40
Closes #52
Closes #55
Changes
Testing
http://23.23.4.125:8051/