Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug in test dataset splitting #33

Open
nobrowning opened this issue Aug 3, 2021 · 1 comment
Open

a bug in test dataset splitting #33

nobrowning opened this issue Aug 3, 2021 · 1 comment

Comments

@nobrowning
Copy link

I noticed that there is bug in the preprocessing code for 20ng(scripts/data_20ng.py)

docs_ts = [[word2id[w] for w in init_docs[idx_d+num_docs_tr].split() if w in word2id] for idx_d in range(tsSize)]

missing the idx_permute index convert

@Littleele
Copy link

in line 91 idx_permute = np.random.permutation(num_docs_tr).astype(int)
the idx_permute is num_docs_tr size, so for test set there is no need to add the index convert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants