Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Ask for confirmation if the count of the data pull is too large. #4

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

alip
Copy link
Contributor

@alip alip commented Dec 13, 2016

The definition of large is relative of course, so right now I'll hardcode it to 10000 based on empirical data. I am open for other suggestions.

Where $large is hardcoded as 10000 based on empirical data.
@alip alip requested a review from roa December 14, 2016 08:26
@alip alip self-assigned this Dec 14, 2016
Copy link
Member

@roa roa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@alip alip merged commit 1d11600 into master Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants