This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Dont rely on GitHub import path format #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewslotin
force-pushed
the
dont_rely_on_github_import_path_format
branch
from
b753ba0
to
a62e732
Compare
roa
added a commit
that referenced
this pull request
Nov 5, 2015
…rmat Dont rely on GitHub import path format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking for Gofiles for installed packages to resolve their dependencies
goemassumes that each package name follows GitHub repository naming patterngithub.com/<username>/<project>and tries to look for.go/src/github.com/<username>/<project>/Gofile. This assumption is not always true, for example some ofgolang.org/x/...packages importgoogle.golang.org/cloud. As the resultgoemis trying to statgoogle.golang.org/cloud/.travis.yml/Gofilewhich returns an error different fromos.ErrNotExistand causes premature exit leaving rest of the dependencies not installed.