HEADERNAME may not start with '-'. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"t:" and "f:" are valid HEADERNAMEs.
|
Yes, I think that allowing - at the start of the regex for HEADERNAME is just a typo. We should simply remove this. It's just a corner case that's tricky to implement in the parser and serves no purpose. |
adl
added a commit
that referenced
this pull request
Feb 24, 2015
HEADERNAME may not start with '-'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifier may not start with
-, so that--ABORT--may not be mistaken as an identifier. And although we state that HEADERNAME are like identifiers followed by:, the given regex allows them to start with-. This raises the question of whether--ABORT--:is a HEADERNAME, or if is--ABORT--followed by:.I suggest we simply fix the HEADERNAME definition to disallow a leading
-. This is what is implemented in Spot 1.99a and jhoafparser 1.0.1 already. (But maybe there is a development version of jhoafparser that recognizes-:as a HEADERNAME by now, because this is one case in the test-suite developed by Joachim.)