Resolves #153, prevents LRS grouping from overwriting existing groupings #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracking, busy week but will review when I can. |
|
Hi @adl-trey, sorry to be a pest but I was wondering if you would know when this might be reviewed? |
|
Oh not at all! We've been buried in I/ITSEC prep and other popups so a reminder is welcomed. I'll try and get to this today. |
|
Looking at this now, not really familiar with the context property so I'll be reading up on that for a bit to make sure nothing weird's going on. |
|
Ok, I don't see anything wrong with this, merging and will update the Readme / dist shortly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.