Line 871, column 13, Michael Hoffmeister, 2020-08-01
If further data specifications exist (in future), add here
Line 169, column 17, MIHO, 2020-08-01
The check for role class or requirements is still questionable
but seems to be correct (see below)
Question MIHO: I dont understand the determinism behind that!
WIEGAND: me, neither ;-)
Wiegand: ich hab mir von Prof.Drath nochmal erklären lassen, wie SupportedRoleClass und
RoleRequirement verwendet werden:
In CAEX2.15(aktuelle AML Version und unsere AAS Mapping Version):
1.Eine SystemUnitClass hat eine oder mehrere SupportedRoleClasses, die ihre „mögliche Rolle
beschreiben(Drucker / Fax / kopierer)
2.Wird die SystemUnitClass als InternalElement instanziiert entscheidet man sich für eine
Hauptrolle, die dann zum RoleRequirement wird und evtl. Nebenklassen die dann
SupportedRoleClasses sind(ist ein Workaround weil CAEX2.15 in der Norm nur
ein RoleReuqirement erlaubt)
InCAEX3.0(nächste AMl Version):
1.Wie bei CAEX2.15
2.Wird die SystemUnitClass als Internal Elementinstanziiert werden die verwendeten Rollen
jeweils als RoleRequirement zugewiesen (in CAEX3 sind mehrere RoleReuqirements nun erlaubt)
Line 1436, column 45, Michael Hoffmeister, 2020-08-01
fill out
eds.hasDataSpecification by using outer attributes
Line 42, column 5, mristin, 2020-10-05
The class is unused since all its tests were disabled temporarily and
will be fixed in the near future.
Once the tests are enabled, please remove this Resharper directive.
Line 92, column 9, mristin, 2020-10-05
This test has been temporary disabled so that we can merge in the branch
MIHO/EnhanceDocumentShelf. The test should be fixed in a future pull request and we will then re-enable it
again.
Please do not forget to remove the Resharper directive at the top of this class.
[TestCase(".xml")]
dead-csharp ignore this comment
Line 132, column 9, mristin, 2020-10-05
This test has been temporary disabled so that we can merge in the branch
MIHO/EnhanceDocumentShelf. The test should be fixed in a future pull request and we will then re-enable it
again.
Please do not forget to remove the Resharper directive at the top of this class.
[Test]
dead-csharp ignore this comment
Line 155, column 17, mristin, 2020-09-17
Remove autofix once XSD and Aasx library in sync
Package has been loaded, now we need to do an automatic check & fix.
This is necessary as Aasx library is still not conform with the XSD AASX schema and breaks
certain constraints (*e.g.*, the cardinality of langString = 1..*).
Line 1843, column 13, Michael Hoffmeister, 1970-01-01
in V1.0, shall be a list of embeddedDataSpecification
Line 2561, column 13, Michael Hoffmeister, 1970-01-01
Qualifiers not working!
Line 2921, column 29, Michael Hoffmeister, 1970-01-01
Operation
Line 3900, column 25, Michael Hoffmeister, 1970-01-01
use aasenv serialzers here!
Line 3925, column 29, Michael Hoffmeister, 1970-01-01
use aasenv serialzers here!
Line 4032, column 25, Michael Hoffmeister, 1970-01-01
use aasenv serialzers here!
Line 4061, column 29, Michael Hoffmeister, 1970-01-01
use aasenv serialzers here!
Line 4088, column 29, Michael Hoffmeister, 1970-01-01
use aasenv serialzers here!
Line 1409, column 25, MIHO, 2020-08-30
this does not prevent the corner case, that we could have
* multiple dataSpecificationIEC61360 in this list, which would be an error
Line 3466, column 13, MIHO, 2020-08-27
According to spec, cardinality is [1..1][1..n]
Line 3470, column 13, MIHO, 2020-08-27
According to spec, cardinality is [0..1][1..n]
Line 3501, column 13, MIHO, 2020-08-27
According to spec, cardinality is [0..1][1..n]
Line 3780, column 13, MIHO, 2020-08-30
align wording of the member ("embeddedDataSpecification") with the
* wording of the other entities ("hasDataSpecification")
Line 4537, column 33, MIHO, 2020-08-26
not very elegant, yet. Avoid temporary collection
Line 5296, column 13, Michael Hoffmeister, 2020-08-01
check, if Json has Qualifiers or not
Line 5788, column 17, MIHO, 2021-07-08
obvious error .. info should receive semanticId .. but would change
Line 5882, column 17, MIHO, 2021-08-12
consider using:
Activator.CreateInstance(pl.GetType(), new object[] { pl })
Line 6247, column 21, MIHO, 2020-07-31
would be nice to use IEnumerateChildren for this ..
Line 6391, column 13, MIHO, 2021-10-18
there are overlaps of this new function with
* this old function: FindFirstAnySemanticId(Key[] semId ..
* clarify/ refactor
Line 290, column 21, Michael Hoffmeister, 2020-08-01
use a unified function to create a serializer
Line 476, column 21, Michael Hoffmeister, 2020-08-01
use a unified function to create a serializer
Line 519, column 25, Michael Hoffmeister, 2020-08-01
use a unified function to create a serializer
Line 554, column 25, Michael Hoffmeister, 2020-08-01
use a unified function to create a serializer
Line 611, column 37, MIHO, 2021-01-02
check again.
* Revisiting this code after a while, and after
* the code has undergo some changes by MR, the following copy command needed
* to be amended with a if to protect against self-copy.
Line 212, column 17, MIHO, 2020-11-12
replace with Regex for multi language. Ideally have Exception messages
always as English.
Line 83, column 13, Robin, 2020-09-03
please check
Line 99, column 13, Robin, 2020-09-03
please check
Line 555, column 13, krahlro-sick, 2020-07-31
make sure that there are no duplicates
Line 395, column 25, krahlro-sick, 2021-02-03
HTML-decode SI code
Line 820, column 13, krahlro-sick, 2021-02-23
This logic is copied from EclassUtils.GenerateConceptDescription -- does
Line 126, column 13, Robin, 2020-09-03
MIHO is not sure, if the data spec reference is correct; please check
Line 142, column 13, Robin, 2020-09-03
MIHO is not sure, if the data spec reference is correct; please check
Line 158, column 13, Robin, 2020-09-03
check this code
Line 317, column 13, jtikekar, 2022-04-04
Change
Line 1212, column 13, jtikekar, 2022-04-04
Change duting V3 upgrade
Line 374, column 13, jtikekar, 2022-04-04
Change
Line 740, column 13, jtikekar, 2022-04-04
Change during refactoring
Line 368, column 9, jtikekar, 2022-04-04
Change during v3 upgrade
Line 381, column 9, jtikekar, 2022-04-04
Change during v3 upgrade
Line 2153, column 13, jtikekar, 2022-04-04
Change
Line 4094, column 13, jtikekar, 2022-04-04
Change duting V3 upgrade
Line 4175, column 9, jtikekar, 2022-04-04
Change to V3
Line 4190, column 9, jtikekar, 2022-04-04
Change during v3 upgrade
Line 221, column 13, jtikekar, 2022-04-04
May need to change response.Result
Line 253, column 13, jtikekar, 2022-04-04
May need to change response.Result
Line 365, column 13, jtikekar, 2022-04-04
? if (type.IsAssignableFrom(typeof(Stream)))
Line 235, column 17, jtikekar, 2022-04-04
Change
Line 262, column 21, jtikekar, 2022-04-04
Change
Line 227, column 29, MIHO, 2021-05-28
extend Parse() to parse also ECLASS, IEC CDD
Line 220, column 17, MIHO, 2022-06-27
improve, this is not always the case
Line 231, column 17, MIHO, 2022-06-27
improve, this is not always the case
Line 127, column 9, MIHO, 2021-06-06
move code to AasForms source file
Line 35, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 124, column 13, MIHO, 2021-06-30
check use of Url()
Line 178, column 17, mristin, 2020-11-13
@MIHO please check -- Options should be null, not empty?
Line 304, column 17, Marko Ristin, 2021-07-09
not clear, how this test could pass. As of today,
Line 308, column 17, Marko Ristin, 2021-07-09
could not fix
Line 36, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 337, column 17, MIHO, 2020-12-31
check for ANYUI MIHO
Line 366, column 13, MIHO, 2021-12-27
consider extending for better testing or
* script running
Line 1649, column 29, MIHO, 2021-10-28
Check, if a better solution exists
* to instrument event updates in a way that they're automatically
* visualized
Line 1754, column 49, MIHO, 2021-10-09
prepare path to be relative
Line 1765, column 49, MIHO, 2021-10-09
prepare path to be relative
Line 2459, column 17, MIHO, 2021-06-08
find the root cause instead of doing a quick-fix
Line 959, column 13, MIHO, 2020-12-21
function & if-clause is obsolete
Line 1122, column 17, Michael Hoffmeister, 2020-08-01
possibly [Jump] button??
Line 1312, column 25, MIHO, 2021-02-16
this mechanism is ugly and only intended to be temporary!
It shall be replaced (after intergrating AnyUI) by a better repo handling
Line 1333, column 25, Michael Hoffmeister, 2020-08-01
Needs to be revisited
Line 2304, column 17, MIHO, 2021-08-17
check if more SME types to serialize
Line 340, column 25, MIHO, 2021-06-22
think of converting Referable to IAasElement
Line 572, column 33, Michael Hoffmeister, 2020-08-01
Operation complete?
Line 611, column 33, Michael Hoffmeister, 2020-08-01
Operation complete?
Line 630, column 33, MIHO, 2021-08-18
createAtIndex missing here
Line 1504, column 37, MIHO, 2021-08-17
create events for CDs are not emitted!
Line 1885, column 13, MIHO, 2020-09-01
extend the lines below to cover also data spec. for units
Line 3689, column 25, MIHO, 2021-02-16
this mechanism is ugly and only intended to be temporary!
It shall be replaced (after intergrating AnyUI) by a better repo handling
Line 433, column 17, MIHO, 2021-07-08
check for completeness
Line 24, column 9, MIHO, 2021-06-28
eliminate ModifyRepo. Right now, it is used as boolean flag while editing
Line 146, column 17, jtikekar, 2022-04-04
aasIds?
Line 187, column 13, jtikekar, 2022-04-04
Change
Line 67, column 73, jtikekar, 2022-04-04
Based on file
Line 257, column 9, MIHO, 2021-01-07
rename to plural
Line 248, column 17, all, 2021-01-30
check periodically for supported element types
Line 306, column 13, MIHO, 2021-01-03
check to handle more SMEs for AasEventMsgUpdateValue
Line 307, column 13, MIHO, 2021-01-04
ValueIds still missing ..
Line 651, column 17, MIHO, 2021-11-07
refactor use of SetParentsForSME to be generic
Line 752, column 17, MIHO, 2021-05-21
make sure, this is required by the specification!
Line 788, column 13, MIHO, 2021-10-09
Modify missing!!
Line 836, column 17, MIHO, 2021-05-28
to be implemented
Line 845, column 17, MIHO, 2021-05-28
to be implemented
Line 854, column 17, MIHO, 2021-05-28
to be implemented
Line 362, column 9, MIHO, 2021-08-17
check if to refactor/ move to another location
* and to extend to Submodels ..
Line 375, column 13, MIHO, 2021-08-17
add more type specific conversions?
Line 451, column 29, MIHO, 2021-01-03
check to handle more SMEs for AasEventMsgUpdateValue
Line 65, column 13, MIHO, 2020-12-25
think of creating a temp file which resemebles the source file
Line 160, column 13, MIHO, 2021-02-01
check, if demo option is still required
Line 330, column 9, MIHO, 2020-08-05
refacture this with DispEditHelper.cs
Line 107, column 13, MIHO, 2021-01-08
check, how to make absolute
Line 143, column 17, MIHO, 2020-12-15
consider removing "indirectLoadSave" from AdminShellPackageEnv
Line 122, column 9, MIHO, 2021-01-08
add SubmodelIds
Line 202, column 17, MIHO, 2020-07-31
check if commented out because of non-working multi-select?
Line 2373, column 25, MIHO, 2021-06-11
Submodel needs to be set in the long run
Line 62, column 9, MIHO, 2021-12-24
check if to refactor multiplicity handling as utility
Line 295, column 17, MIHO, 2021-01-04
consider at least to include MLP, as well
Line 1985, column 21, MIHO, 2021-11-09
AasxPlugPlotting does not allow all options
Line 1, column 1, MIHO, 2020-08-06
lookup SOURCE!
Line 45, column 9, MIHO, 2021-11-17
damned, weird dependency reasons between
* .netstandard2.0 and .net472 seem NOT TO ALLOW referring to AasxIntegrationBase.
* Fix
Line 144, column 17, MIHO, 2020-08-02
when dragging the divider between elements tree and browser window,
Line 30, column 9, Andreas Orzelski, 2020-08-01
The signature file and [Content_Types].xml can be tampered?
Line 180, column 21, Andreas Orzelski, 2020-08-01
Is package according to the Logical model of the AAS?
Line 214, column 17, Andreas Orzelski, 2020-08-01
is package sealed? => no other signatures can be added?
Line 217, column 17, Andreas Orzelski, 2020-08-01
The information from the analysis
-> return as an object (list of enums with the issues/warings???)
Line 263, column 21, mristin, 2020-10-30
add json once the validation is in place.
Michael Hoffmeister had it almost done today.
Path.Combine(
TestContext.CurrentContext.TestDirectory,
"TestResources\\AasxToolkit.Tests\\sample.json")
dead-csharp ignore this comment
Line 10, column 1, MIHO, 2020-08-03
check SOURCE
Line 280, column 33, MIHO, 2020-08-06
check, which namespace shall be used
Line 20, column 1, MIHO, 2020-08-29
The UA mapping needs to be overworked in order to comply the joint aligment with I4AAS
Line 21, column 1, MIHO, 2020-08-29
The UA mapping needs to be checked for the "new" HasDataSpecification strcuture of V2.0.1
Line 695, column 21, MIHO, 2020-08-06
check (again) if reference to CDs is done are shall be done
Line 986, column 13, MIHO, 2020-08-06
not sure if to add these
Line 1087, column 13, MIHO, 2020-08-06
use the collection element of UA?
Line 1423, column 29, MIHO, 2020-08-06
decide to from where the name comes
Line 1426, column 29, MIHO, 2020-08-06
description: get "en" version which is appropriate?
Line 1429, column 29, MIHO, 2020-08-06
parse UA data type out .. OK?
Line 1438, column 33, MIHO, 2020-08-06
description: get "en" version is appropriate?
Line 1447, column 37, MIHO, 2020-08-06
this any better?
Line 1451, column 37, MIHO, 2020-08-06
description: get "en" version is appropriate?
Line 1795, column 13, MIHO, 2020-08-06
check, if to make super classes for UriDictionaryEntryType?
Line 666, column 9, MIHO, 2020-08-06
check, if this is valid use of the SDK. MIHO added this
Line 173, column 13, MIHO, 2020-08-04
To be checked by Andreas. All applications have software certificates
Line 24, column 1, Michael Hoffmeister, 2020-08-01
Fraunhofer IOSB: Check ReSharper to be OK
Line 30, column 1, Michael Hoffmeister, 1970-01-01
License
Line 31, column 1, Michael Hoffmeister, 1970-01-01
Fraunhofer IOSB: Check ReSharper
Line 27, column 1, Michael Hoffmeister, 2020-08-01
Fraunhofer IOSB: Check ReSharper settings to be OK
Line 1381, column 13, MIHO, 2020-12-21
can be realized without tedious central dispatch?
Line 275, column 13, MIHO, 2021-11-09
check, if clearing selected items on refresh is required
Line 496, column 13, MIHO, 2021-01-04
check to replace all occurences of RefreshFromMainData() by
* making the tree-items ObservableCollection and INotifyPropertyChanged
Line 812, column 21, MIHO, 2020-07-21
was because of multi-select
Line 159, column 9, MIHO, 2020-12-24
check if required
Line 35, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 35, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 38, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 40, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 42, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 41, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 35, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 37, column 9, MIHO, 2020-12-21
make DiaData non-Nullable
Line 124, column 21, MIHO, 2021-01-09
check to use moveup/down of the PackageContainerListBase
Line 135, column 21, MIHO, 2021-01-09
check to use moveup/down of the PackageContainerListBase
Line 139, column 9, MIHO, 2020-12-24
check if to move/ refactor these functions
Line 51, column 13, MIHO, 2020-08-03
see equivalent function in AmlImport.cs; may be re-use
Line 219, column 41, MIHO, 2020-08-06
spec/example files seem not to be in a final state
Line 242, column 13, MIHO, 2020-08-06
remove this, if not required anymore
Line 426, column 13, MICHA, 2020-10-04
check if font is set correctly ..
Line 427, column 13, MICHA, 2020-10-04
seems, that for Textblock the alignement DOES NOT WORK!
Line 76, column 13, MIHO, 2020-09-18
remove this test code