Use platform-specific path separator in makeRelativePath function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
added a commit
that referenced
this pull request
Sep 19, 2014
Use platform-specific path separator in makeRelativePath function
miguelsousa
pushed a commit
that referenced
this pull request
Jul 5, 2015
add autohintlib to BuildAll target dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discussed this issue on the AFDKO mailing list:
https://groups.google.com/forum/#!topic/uafdkoml/2Xpq5ZzAUU8
Basically, the
makeRelativePathfunction in MakeOTF.py is enforcing UNIX forward slashes/instead of picking the required OS-specific path separator. This makes the ttx command fail when compiling TTF/OTF fonts on Windows -- where a backslash\is required instead.Cheers,
Cosimo