Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build_wheels.yml] Remove env installation of libxml2 for Windows #1518

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

kaydeearts
Copy link
Collaborator

@kaydeearts kaydeearts commented Jun 15, 2022

Attempting to fix pre-release fail where Windows cannot install libxml2 with these commands in the env (it needs to run ExternalProject_Add in cmake!). I think removing these commands should help, since the other wheels files (testpythonpackage.yml) build that way, but we'll have to test with another prerelease push

Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that did the trick 👍

@kaydeearts kaydeearts merged commit b02b850 into develop Jun 15, 2022
@kaydeearts kaydeearts deleted the kd-buildwheels_windows_fix branch June 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants