Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] write a vsindex before the first blend (if needed) #845

Merged
merged 1 commit into from
Jul 16, 2019

Conversation

cjchapman
Copy link
Contributor

@cjchapman cjchapman commented Jul 15, 2019

Prior to this change, tx was not writing vsindex in CFF2 output, even if it was needed. The result was char strings that would not rasterize correctly.

With this change, tx will write a vsindex before the first blend if the vsindex is not zero.

Copy link
Contributor

@readroberts readroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I see that the logic adds the vsindex argument and operator, if non-zero, before the first blend operator and its arguments, which matches OpenType spec. The test files changes as expected

@miguelsousa miguelsousa merged commit f06e58c into develop Jul 16, 2019
@miguelsousa miguelsousa deleted the cjc-tx-write-vsindex branch July 16, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants