Drop python 3.6; update to latest afdko 4.0.1 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2024
anthrotype
force-pushed
the
update-afdko
branch
from
34f3639
to
6a308e8
Compare
upstream afdko does not build for that.. simply trying to see if it helps unblocking the CI build failures
This reverts commit 723f302.
afdko doesn't seem to be using MSBuild any longer upload-artifact@v4 fails with artifacts with sane name and am too lazy to figure out how to make unique names right now
I think this is what making the build fail, because it's using mingw64 compiler instead of MSVC
the afdko seems to be using that, maybe it fixes the failing windows build?
This reverts commit 5ec2467.
so that it will use scikit-build
like afdko does
we're now delegating all this to afdko's own setup.py which uses scikit-build and cmake
anthrotype
force-pushed
the
update-afdko
branch
from
3bd2419
to
784318e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.