-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/angular ssr #876
Merged
niekraaijmakers
merged 42 commits into
adobe:develop
from
niekraaijmakers:issue/angular-ssr
Jan 20, 2022
Merged
Issue/angular ssr #876
niekraaijmakers
merged 42 commits into
adobe:develop
from
niekraaijmakers:issue/angular-ssr
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s chosen as FE module for now.
Adding information to describe a minimum use case where a custom model client is needed.
Issue/react ssr - updating readme information
… cuts archetype complexity and also prevents an extra NPM install which can save lots of time.
… cuts archetype complexity and also prevents an extra NPM install which can save lots of time.
… clean and stable now!
…gular-ssr # Conflicts: # README.md # src/main/archetype/pom.xml # src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/accordion/new/.content.xml # src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/carousel/new/.content.xml # src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/container/new/.content.xml # src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/tabs/new/.content.xml # src/main/archetype/ui.config/src/main/content/jcr_root/apps/__appId__/osgiconfig/config/com.adobe.cq.remote.content.renderer.impl.factory.ConfigurationFactoryImpl~__appId__.cfg.json # src/main/archetype/ui.frontend.angular/README.md # src/main/archetype/ui.frontend.angular/angular.json # src/main/archetype/ui.frontend.angular/package.json # src/main/archetype/ui.frontend.angular/server.ts # src/main/archetype/ui.frontend.angular/src/app/app.component.ts # src/main/archetype/ui.frontend.angular/src/app/app.module.ts # src/main/archetype/ui.frontend.angular/src/environments/environment.prod.ts # src/main/archetype/ui.frontend.angular/src/environments/environment.ts # src/main/archetype/ui.frontend.angular/tsconfig.server.json # src/main/archetype/ui.frontend.react/.env.development # src/main/archetype/ui.frontend.react/.gitignore # src/main/archetype/ui.frontend.react/README.md # src/main/archetype/ui.frontend.react/actions/ssr/index.js # src/main/archetype/ui.frontend.react/package.json # src/main/archetype/ui.frontend.react/pom.xml # src/main/archetype/ui.frontend.react/src/components/Text/Text.js # src/main/archetype/ui.frontend.react/src/index.js # src/main/archetype/ui.frontend.react/src/server/aem-processor.functions.js # src/main/archetype/ui.frontend.react/src/server/express.js # src/main/archetype/ui.frontend.react/webpack.config.adobeio.js # src/main/archetype/ui.frontend.react/webpack.config.express.js # src/main/resources/META-INF/archetype-post-generate.groovy # src/main/resources/META-INF/maven/archetype-metadata.xml # src/test/resources/projects/basic/archetype.properties # src/test/resources/projects/cif-cloud/archetype.properties # src/test/resources/projects/cif/archetype.properties # src/test/resources/projects/cloud/archetype.properties # src/test/resources/projects/forms-communications-cloud/archetype.properties # src/test/resources/projects/frontend-angular-ssr/archetype.properties # src/test/resources/projects/frontend-angular/archetype.properties # src/test/resources/projects/frontend-general/archetype.properties # src/test/resources/projects/frontend-react-ssr/archetype.properties # src/test/resources/projects/frontend-react/archetype.properties
This pull request introduces 3 alerts and fixes 1 when merging 14e133b into fa6f3e3 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 1 when merging 9dbb612 into fa6f3e3 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts when merging 05f0c56 into fa6f3e3 - view on LGTM.com new alerts:
|
CezCz
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling IORuntime for Angular SSR.
Related Issue
#875
Motivation and Context
This is needed to enable customers with Angular / SPA editor to use aem as a cloud service.
How Has This Been Tested?
Local testing with openwhisk / local aem.
Screenshots (if appropriate):
Types of changes
Checklist: