Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/angular ssr #876

Merged
merged 42 commits into from
Jan 20, 2022
Merged

Conversation

niekraaijmakers
Copy link
Collaborator

Description

Enabling IORuntime for Angular SSR.

Related Issue

#875

Motivation and Context

This is needed to enable customers with Angular / SPA editor to use aem as a cloud service.

How Has This Been Tested?

Local testing with openwhisk / local aem.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Niek Raaijmakers and others added 30 commits April 27, 2021 17:49
Adding information to describe a minimum use case where a custom model client is needed.
Issue/react ssr - updating readme information
… cuts archetype complexity and also prevents an extra NPM install which can save lots of time.
… cuts archetype complexity and also prevents an extra NPM install which can save lots of time.
Niek Raaijmakers added 8 commits May 6, 2021 08:43
…gular-ssr

# Conflicts:
#	README.md
#	src/main/archetype/pom.xml
#	src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/accordion/new/.content.xml
#	src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/carousel/new/.content.xml
#	src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/container/new/.content.xml
#	src/main/archetype/ui.apps/src/main/content/jcr_root/apps/__appId__/components/tabs/new/.content.xml
#	src/main/archetype/ui.config/src/main/content/jcr_root/apps/__appId__/osgiconfig/config/com.adobe.cq.remote.content.renderer.impl.factory.ConfigurationFactoryImpl~__appId__.cfg.json
#	src/main/archetype/ui.frontend.angular/README.md
#	src/main/archetype/ui.frontend.angular/angular.json
#	src/main/archetype/ui.frontend.angular/package.json
#	src/main/archetype/ui.frontend.angular/server.ts
#	src/main/archetype/ui.frontend.angular/src/app/app.component.ts
#	src/main/archetype/ui.frontend.angular/src/app/app.module.ts
#	src/main/archetype/ui.frontend.angular/src/environments/environment.prod.ts
#	src/main/archetype/ui.frontend.angular/src/environments/environment.ts
#	src/main/archetype/ui.frontend.angular/tsconfig.server.json
#	src/main/archetype/ui.frontend.react/.env.development
#	src/main/archetype/ui.frontend.react/.gitignore
#	src/main/archetype/ui.frontend.react/README.md
#	src/main/archetype/ui.frontend.react/actions/ssr/index.js
#	src/main/archetype/ui.frontend.react/package.json
#	src/main/archetype/ui.frontend.react/pom.xml
#	src/main/archetype/ui.frontend.react/src/components/Text/Text.js
#	src/main/archetype/ui.frontend.react/src/index.js
#	src/main/archetype/ui.frontend.react/src/server/aem-processor.functions.js
#	src/main/archetype/ui.frontend.react/src/server/express.js
#	src/main/archetype/ui.frontend.react/webpack.config.adobeio.js
#	src/main/archetype/ui.frontend.react/webpack.config.express.js
#	src/main/resources/META-INF/archetype-post-generate.groovy
#	src/main/resources/META-INF/maven/archetype-metadata.xml
#	src/test/resources/projects/basic/archetype.properties
#	src/test/resources/projects/cif-cloud/archetype.properties
#	src/test/resources/projects/cif/archetype.properties
#	src/test/resources/projects/cloud/archetype.properties
#	src/test/resources/projects/forms-communications-cloud/archetype.properties
#	src/test/resources/projects/frontend-angular-ssr/archetype.properties
#	src/test/resources/projects/frontend-angular/archetype.properties
#	src/test/resources/projects/frontend-general/archetype.properties
#	src/test/resources/projects/frontend-react-ssr/archetype.properties
#	src/test/resources/projects/frontend-react/archetype.properties
@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 3 alerts and fixes 1 when merging 14e133b into fa6f3e3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Syntax error
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 2 alerts and fixes 1 when merging 9dbb612 into fa6f3e3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@niekraaijmakers niekraaijmakers requested review from cziegeler and CezCz and removed request for cziegeler January 20, 2022 09:11
@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2022

This pull request introduces 2 alerts when merging 05f0c56 into fa6f3e3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@niekraaijmakers niekraaijmakers merged commit d629d79 into adobe:develop Jan 20, 2022
@niekraaijmakers niekraaijmakers deleted the issue/angular-ssr branch January 20, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants