Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Authors can be "links" #26

Closed
kptdobe opened this issue Oct 25, 2021 · 3 comments · Fixed by #32
Closed

Authors can be "links" #26

kptdobe opened this issue Oct 25, 2021 · 3 comments · Fixed by #32
Assignees

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Oct 25, 2021

Check page: https://main--blog--adobe.hlx3.page/ko/publish/2021/10/21/digital-transformation-determining-the-future-of-healthcare

The author links points to https://main--blog--adobe.hlx3.page/ko/authors/------.

2 issues here:

  1. During the content import, the "author" is converted into a meta property. But in the source document, the author can be a link: this is how we solved the problem when the author link cannot be deducted from author name (especially true in KO and JP or for authors with special characters in the name). The link gets lost during the import (I have added now the link on the example page to observe the next issue).
  2. If we change the author property in the metadata table to be a link, the link is removing during rendering.

Several options:

  1. Add support for a link in the author metadata property in Word - the link should then be outputted as another meta because the author meta tag does not support it. There is no standard or OG representing it. We should invent one (author:url ? like in og:image:url). The pipeline should then be extended.
  2. Split the 2, have another row with author:link or authorLink (no necessarily user friendly).
  3. Create a new block for it (really complicated).

In all cases, the importer must be adjusted.

@fkakatie @davidnuescheler @rofe WDYT ?

@kptdobe kptdobe changed the title Authors could be links Authors can be "links" Oct 25, 2021
@rofe
Copy link
Contributor

rofe commented Oct 25, 2021

How about...
4. Always use the latin author name in the author meta property (so its translation into an author link would be straight forward) and fetch the actual display name from the generated link? Or even better:
5. The value of the author meta property could be any string, I suppose, so it could also be a URL, right? so why not put the link to the author page there, and fetch the display name from there? Word would probably create links out of these URLs if authors aren't careful, but we could easily deal with that in the pipeline.

@kptdobe
Copy link
Contributor Author

kptdobe commented Oct 25, 2021

  1. Only the the non-latin version is important, the rest is a trick to find the author page. The latin name might still need some filtering to find the url. It might not be one-to-one. Finally, we display the non-latin version in the LCP block, we would need to fetch it first to be able to show something.
  2. from https://www.w3.org/TR/2011/WD-html5-author-20110809/the-meta-element.html#meta-author: The value must be a free-form string giving the name of one of the page's authors + same pb than about.

@kptdobe
Copy link
Contributor Author

kptdobe commented Oct 27, 2021

After chatting with @davidnuescheler, decision is: use a separate metadata property (Author URL).
I'll change the importer to convert the links into 2 separate properties and I'll adjust the code to handle the Author URL meta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants