This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Sprint -> Release #462
Merged
Sprint -> Release #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge this after Release 43. |
Conflicts: appshell/version.rc installer/mac/buildInstaller.sh installer/win/brackets-win-install-build.xml
|
Ready to rock! Thanks @marcelgerber. |
| @@ -43,7 +43,7 @@ BEGIN | |||
| BEGIN | |||
| VALUE "CompanyName", "brackets.io\0" | |||
| VALUE "FileDescription", "\0" | |||
| VALUE "FileVersion", "Sprint 44\0" | |||
| VALUE "FileVersion", "Release 44\0" | |||
There was a problem hiding this comment.
Damn. It should be Release 0.44, right?
There was a problem hiding this comment.
Yes, how could I have missed this... ;-) Let's change it and submit the change.
There was a problem hiding this comment.
Would you like to fix it or should I do?
There was a problem hiding this comment.
I can fix and submit it.
There was a problem hiding this comment.
@marcelgerber I have fixed it with #465
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://trello.com/c/atMTdx6l/1313-brackets-7828-should-be-consistent-about-release-vs-sprint-issue.
Similar to adobe/brackets#8680.
@redmunds