Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Language modes added via extensions don't update the extension-language map #11252

Closed
bobrocke opened this issue Jun 11, 2015 · 4 comments
Closed

Comments

@bobrocke
Copy link

In a conversion with @TomMalbran on Slack, he found that:

"Yes it seems that the internal map of extension to language does not get updated when a new language is added. Is just a problem because the language is added from an extension, which is loaded after the map is set. Is a bug that needs to be fixed in master. It even fails with the less language which is defined in a default extension."

@marcelgerber
Copy link
Contributor

Repro steps, for easier understanding:

  1. Create a new file "test.css"
  2. In the language picker in the lower right, choose the "LESS" language
  3. Open the picker again and click "Set as default for .css files"
  4. Close and re-open Brackets

Result:
The language indicator says "CSS" again.

Expected:
The language indicator says "LESS".

Notice how LESS is not defined in the core, but rather in the LESSSupport extension.

@marcelgerber
Copy link
Contributor

Looks like this is actually a dupe of #10177.

I'm inclined to close the other one, though, as this issue points out this also happens with the LESS language, and the repro steps are quite a lot easier.

@saurabh95
Copy link
Contributor

@marcelgerber @zaggino I am not able to repro the issue on the current master using the above repro steps, Could you verify it again?

@zaggino
Copy link
Contributor

zaggino commented Feb 20, 2017

We've merged some fixes around this so this might be fixed in master already as a side-effect, closing.
@marcelgerber please re-open if you can still replicate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@zaggino @marcelgerber @bobrocke @saurabh95 and others