[Unit Test Failure] Not all Test Windows are closed even when tests succeed

[redmunds]

When I run the Live Development Integration tests, they report "Complete. No failures.", but 2 test windows are left open. Both Mac and Windows.

I am seeing the same with the UpdateNotification tests, so this doesn't seem to be caused by recent Live Development changes.

[redmunds]

I'll run git bisect to see if I can find the change that broke it.

[redmunds]

This was introduced by this change: #3153

Assigning to @RaymondLim

[njx]

Interesting. I bet this breaks the tests because some tests probably leave unsaved changes; in the past, we would just go ahead and close the window due to #3152, which turns out to be what you want for tests, but not for the real product :) Maybe we should just change SpecRunner.closeTestWindow() to make it so it can force the window to close even if there are unsaved changes (would probably have to add some internal API in Brackets to allow this).

[peterflynn]

FBNC @redmunds since the fix has been merged

[redmunds]

Confirmed. Closing.