Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Introduce our own window property to distinguish between test windows from normal Brackets window. #3226

Merged
merged 1 commit into from
Mar 22, 2013

Conversation

RaymondLim
Copy link
Contributor

This fixes issue #3219.

@ghost ghost assigned jasonsanjose Mar 22, 2013
@jasonsanjose
Copy link
Member

I tested the fix on mac and it works, I don't see any test windows remaining open. However, the docs in ShellAPI aren't very clear. When executeCommand returns false, what/who is that signaling?

I understand that no commands are run if there are any modal dialogs open. I also understand that for for Commands.FILE_CLOSE_WINDOW we swallow this command and return true when any dialogs are open in order to prevent losing unsaved changes, see #3152. I don't see why return false here allows the test window to close. Maybe I'm mis-reading something.

@RaymondLim
Copy link
Contributor Author

The code that returning false when a modal dialog is up is for issue #2616, telling native shell that js command is not handling it.

@jasonsanjose
Copy link
Member

Merging.

jasonsanjose added a commit that referenced this pull request Mar 22, 2013
Introduce our own window property to distinguish between test windows from normal Brackets window.
@jasonsanjose jasonsanjose merged commit 2c1616a into master Mar 22, 2013
@jasonsanjose jasonsanjose deleted the rlim/test-window-closing-issue branch March 22, 2013 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants