Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Cannot double-click folder to select in Open Folder dialog #889

Closed
pthiess opened this issue May 14, 2012 · 4 comments
Closed

Cannot double-click folder to select in Open Folder dialog #889

pthiess opened this issue May 14, 2012 · 4 comments

Comments

@pthiess
Copy link
Contributor

pthiess commented May 14, 2012

  1. File > Open Folder
  2. Double-click on a folder

Results: Nothing happens

Reproduced on Win7. Does not happen on Mac OS X 10.6.


Moved from the Native App Shell issue adobe/brackets-app#120. (already reviewed)

@bchintx
Copy link
Contributor

bchintx commented May 14, 2013

The Windows common dialog launched by our call to SHBrowseForFolder() does not support dbl-click to select. The windows class is sealed and does not even provide a way for us to extend the base functionality to trap the dbl-click. Consequently, to get this functionality, we'd have to re-implement this feature using a different common file dialog.

@bchintx
Copy link
Contributor

bchintx commented May 15, 2013

I noticed in the 'brackets-app' discussion (adobe/brackets-app#120) that NJ suggested trying the newer Windows dialogs to see if they've solved this request. To this end, I've submitted a 'brackets-shell' PR adobe/brackets-shell#247 to test using the newer Windows' Open File dialog in pick folders mode. The new dialog drops in quite nicely and gives a more full-featured dialog with a UI that's more consistent with the Mac implementation.

Unfortunately, it still doesn't support dbl-clicking to select and confirm the dialog. :-(

@redmunds
Copy link
Contributor

This issue is unassigned, so marking "Needs Review".

@njx
Copy link
Contributor

njx commented Apr 14, 2014

Closing - it looks like Win native dialogs no longer support this gesture anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants