Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add @sourceFontFamily LESS variable and use instead of SourceCodePro font-family #10727
In my Brackets fork, I've been discussing ways to save on download size for the in-browser use case. @peterflynn and I discussed making it easier to turn off the use of the Source Code/Sans Pro web fonts in favour of system fonts (it ends up saving me about ~300K of gzipped download, which is great), see https://github.com/humphd/brackets/issues/78.
I've made a start at this, switching all explicit uses of these
Anything else I can do here? I'm not sure how to deal with the explicit use in extensions, especially when I rip out that font-family for the in-browser case.
Sigh... shame there are all those separate references in core extensions.
@humphd I think for now you'll have to live with just having more diffs in your fork than you'd like... unless you feel like biting off the work of getting extensions' LESS to compile in the context of the Brackets core LESS (or at least with a variable declarations file that's shared between them). That would significantly simplify the dark/light theming too, so it's definitely worth doing... but it's also a lot more work than just adding a dozen extra 1-line diffs on your end :-)
The code changes here look ok to me though. Just one thought: what about the
referenced this pull request
Mar 17, 2015
added a commit
this pull request
Mar 17, 2015
FYI, doing follow-up work with this on our branch, I found one more use of