Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Italian strings.js for 1.7 #12081

Merged
merged 5 commits into from
Mar 31, 2016
Merged

Italian strings.js for 1.7 #12081

merged 5 commits into from
Mar 31, 2016

Conversation

Denisov21
Copy link
Contributor

No description provided.

@Denisov21
Copy link
Contributor Author

Hi,
I have some problems of memory for to change this PR from Master to release. Can you help me please?

@petetnt
Copy link
Collaborator

petetnt commented Jan 14, 2016

@Denisov21 you'll need to open another PR AFAIK (that's what I had to do 😹) to change the target branch to release

@Denisov21 Denisov21 changed the title Italian strings.js for 1.6 Italian strings.js for 1.7 Jan 14, 2016
@ficristo
Copy link
Collaborator

I'm not sure but have you tried git rebase release?
Be aware that git rebase can be a "disruptive" command...

@petetnt
Copy link
Collaborator

petetnt commented Jan 14, 2016

@ficristo it's an GitHub limitation, when you send a PR you are locked to branch

@ficristo
Copy link
Collaborator

@petetnt oh, I didn't know...

@petetnt
Copy link
Collaborator

petetnt commented Jan 15, 2016

See isaacs/github#18 it's just not possible 🍨

@abose abose added this to the Release 1.7 milestone Feb 3, 2016
@abose
Copy link
Contributor

abose commented Feb 3, 2016

Tagging @nicolo-ribaudo for review.

nicolo-ribaudo
nicolo-ribaudo reviewed Feb 3, 2016
View reviewed changes
src/nls/it/strings.js
@@ -305,6 +312,7 @@ define({
"CMD_FILE_NEW" : "Nuovo File",
"CMD_FILE_NEW_FOLDER" : "Nuova cartella",
"CMD_FILE_OPEN" : "Apri\u2026",
"CMD_ADD_TO_WORKING_SET" : "Apri un Working Set",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Denisov21 Aggiungi all'area di lavoro

@nicolo-ribaudo
Copy link
Contributor

@Denisov21 I've finished the review

@Denisov21
Copy link
Contributor Author

Thank @nicolo-ribaudo.
I will check and update this PR until Sunday, 07.02

Denis R added 2 commits February 8, 2016 09:05
Update strings.js
c7f2e51 
Update Italian string. I correct many errors!
Update strings.js
448d71a
@Denisov21
Copy link
Contributor Author

@nicolo-ribaudo
I'm ready for another check!! PR update!

@abose
Copy link
Contributor

abose commented Mar 31, 2016

LGTM Merging.
Thanks @Denisov21 @nicolo-ribaudo

@abose abose merged commit 7cf3aa4 into adobe:master Mar 31, 2016
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
translation
Projects
None yet
Milestone
Release 1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@Denisov21 @petetnt @ficristo @abose @nicolo-ribaudo