This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Pflynn/in browser file system #13265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Borrows a bunch of in-browser patches & hacks from the 'glenn/dropbox-integration' branch - Use a placeholder filesystem with hardcoded demo content as the default fs for now, so Brackets can boot up without a login workflow immediately. - But also load an "test-server-file-system" extension from extensions/default (supply your own for now). It can offer a new "Open Project" command that browses in its storage world & invokes openProject() with content from its own fs
…pening external URLs in a new browser tab.
…that it works when invoked right at startup.
Merge branch 'glenn/file-system' into pflynn/in-browser-file-system * glenn/file-system: (56 commits) Change FileSystemManager.createFileSystem() to be async -- allowing filesystem impls time to seed any required initial data, or go through authentication workflows. Fix incorrect JSDoc parameter name. Updated by ALF automation. Update Tern and Acorn to the latest Change decompress-zip to the release Remove methods from eports Fix minor nit Added quick-edit.png for Finnish translation Find in Files title update restore handleWideResults property Deprecate FileUtils.getFilenameExtension() (which includes leading "."), introduce new FileUtils.getFileExtension() (which excludes it). Fixes bug #5365. Clean up Fix #5362 (HTML menu z-index vs. bottom-panel). simplify fix by assuming intent is to type (not insert hint) Code review cleanups Expose code inspection providers for the extensions. Update to decompress-zip that includes fix for our issue. Code review: use more consts in Find; remove unneeded single-tickmark API hasNativeMenus param code cleanup code cleanup ... Conflicts: src/project/ProjectManager.js
…ortcut wraps to second line in some places) -- see notes in bug for the sordid details...
- remove Cut/Copy/Paste menu items since they can't be made to work - remove Check for Update menu item which makse no sense in this context - fix bug where Extension Manager lists all default extensions as user extensions (with broken Remove button) - update message shown when index.html opened directly via file://
all of master into in-browser branch)
…ile-system * origin/master: (1140 commits) Typo fix Set sprint 37 Add session scope Fix signature of `setValueAndSave` Unit test for bug #6609 (Fast file replacement operations can be missed) Dispatch a FileSystem "change" event even when a dir change yields empty added/removed lists - because there's a delay between the change occurring and the time we re-read the dir contents in response, we might see back-to-back changes (e.g. a delete-recreate pair) as a no-op even though something definitely changed. See #6609 for an example bug. Update NOTICE Define self to prevent exception, for #6607 Better doc comment for `Scope.set` Changes based on review comments Maintain the original line endings in preferences files Properly reconfigure the user prefs in test windows. Set preferences are, by default, set in the context in which they are defined. Nits fixed revert submodule add add required success/error callbacks for jstree load_node Nit fixes after PR #6123 Updated by ALF automation. Setting the side toolabr to the top remove unwatchPathsWithPrefix and consilidate with unwatchPath ... Conflicts: package.json src/config.json src/document/DocumentCommandHandlers.js src/extensibility/ExtensionManager.js src/filesystem/FileSystem.js src/filesystem/FileSystemManager.js src/nls/root/strings.js src/project/ProjectManager.js src/styles/brackets_patterns_override.less src/utils/ExtensionLoader.js
- Stub out new user-level preferences storage for now (so Brackets-in-browser always boots up with 'factory default' settings)
…-file-system * upstream/master: (105 commits) Module variable clean up Redefine which files are considered 'useless' Add newline Add Overtype mode improvements Prevent reentrancy of browserReload() Fix additional test Removing .gitignore, .gitattributes, .csvignore, .hgignore from the _exclusionListRegEx. fix css typo Romanian translation update fix some travis cl problems Romanian translation update for sprint 37 Updated by ALF automation. merging Sprint 36 changes in the 'release' branch back into master fix alphabetic ordering Updated by ALF automation. Update CodeMirror to the latest Reorder alphabetically Remove duplicate none value - removed the wrong comment Update LICENSE code review comments ...
…-file-system * upstream/master: (2450 commits) Updated by ALF automation. adding in placeholder -update CM sha Don't misidentify pseudo selector/element as a property while parsing CSS. Changed string NOT_READABLE_ERR, NOT_FOUND_ERR from 'file' to 'file/directory' in ./src/nls/root/strings.js Remove vendor-prefixed properties Fixed unit test Create README with update instructions Update Web Platform Docs Change name, remove blockComment Updated by ALF automation. Update strings-app.js Update urls.js Remove unnecessary whitespace - fix german mispelling Updated by ALF automation. Corrected dutch translation set-release to 1.1 Fix some @link and @see tags Add GitHub Flavored Markdown mode, Add some more Markdown fileExtensions ... Conflicts: src/LiveDevelopment/main.js src/brackets.js src/command/DefaultMenus.js src/document/DocumentCommandHandlers.js src/extensibility/ExtensionManager.js src/nls/root/strings.js src/preferences/PreferencesManager.js src/project/ProjectManager.js src/utils/ExtensionLoader.js
- More places to avoid calling getApplicationSupportDirectory() - Add new default extensions to loading whitelist - Tweak a few strings & comments Note: JSLint does not work in this build due to #9966. For now, you must locally patch your copy of jslint.js to avoid this bug.
- In-browser: Fix fake project path so index.html is auto-opened just as in the desktop version's Getting Started project
…lders (not used in the current demo content, though).
…-file-system * upstream/master: (113 commits) Don't keep focus on mouse clicks on tabs. Refinement of PR #8736: also log LESS errors from the parsing stage to the console (not just the output stage). Also covers cases where the file doesn't exist, for both CSS & LESS. fix documentation issues fix documentation issues convert status styles/tooltips array to object remove unused modules update Copyright year to 2014 fix JSHint issue update name in transport package.json During rename in the tree, allow only default behavior. Fix bug #9966 ([CEF 2171] JSLint doesn't work) - Switch to a private fork of JSLint with the bug fix cherry-picked in so we're not stuck upgrading to a much newer JSLint which has the fix but is significantly stricter / less configurable. fix params passed to internal funcs Ensure that the baseDir for createNewItem is within the project. Further improvde readability by grouping the first part of the expression together. Improve readability of fix. Fixes the exception thrown when the provider list for a given language is empty/undefined. remove errant whitespace from previous commit add methods to align it with LiveDevelopment API remove array from event arguments Clone the providers array returned for a given path to prevent outside modification. ... Conflicts: src/LiveDevelopment/main.js src/document/DocumentCommandHandlers.js
…s for the three cases where FS is used to read internal data files: core extensions, user extensions, user preferences. This way, filesystem impls can easily detect those cases and treat them specially (as the DemoFileSystem does for themes i.e. core extensions).
…e to dummy filesystem so it's easy to see it in action.
…ile-system * origin/master: (180 commits) Update to release 1.3 FR and JP translation fix for index.html file Fix unit test that broke due to a side fix in PR #10413, and enhance tests to verify that search tickmarks are rendered. Only print deprecation warnings for $().on/off() on EventDispatchers once per caller, like other such warnings. Move $() shim into brackets.js normal startup code, since there's no longer any core code that could hit it (only extensions). Fix memory leak in ExtensionManagerViewModel Don't adjust selection if rename fails. Add unit tests for these cases. Fixed typos in docs Update the selected file if a renamed folder is a prefix of the path Use command instead of private method. German Translation Update jQuery -> 2.1.3 Fix for ImageView bug 5960 & 10180 Update README.md Update README.md Update translation Update strings.js Update urls.js Get rid of deprecated calls in LiveDevMultiBrowser Add missing attribute Fixing UX issue of inactive panel getting too dim to read text for dark themes. ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.