This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Unit tests for StaticServerDomain #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look at this first thing in the morning. I'm leaving it unassigned in case @redmunds wants to grab it first. :-) |
|
Reviewing... |
ghost
assigned 
| var pathKey = PATH_KEY_PREFIX + path; | ||
| if (_servers[pathKey]) { | ||
| _servers[pathKey].close(); | ||
| delete _servers[pathKey]; |
There was a problem hiding this comment.
We should delete first, then call close. Close could throw. If it throws, the domain manager will catch the exception and forward a notification to the user (so it's fine that we're not catching the exception here). But we'll be left in this weird state where a broken server is still in the _servers array.
There was a problem hiding this comment.
I'll make this fix since it's just a re-ordering and @njx is out today.
joelrbrandt
added a commit
that referenced
this pull request
Feb 28, 2013
Unit tests for StaticServerDomain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic unit tests for the node code used to implement the HTTP live development server.
@joelrbrandt or @redmunds should look at this.