This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
move starting of static server to live dev start time and fix up some comments #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@redmunds don't review/merge this yet. Needs to be updated for a few changes to main in unit tests that just landed. I'm working on it now. |
Conflicts: src/extensions/default/StaticServer/main.js
|
reviewing |
|
|
||
| _nodeConnectionDeferred.done(function (nodeConnection) { | ||
| if (nodeConnection.connected()) { | ||
| var projectPath = ProjectManager.getProjectRoot().fullPath; |
There was a problem hiding this comment.
I can't remember why the projectPath var was introduced, but it looks like it is no longer necessary since it's only used once.
|
Looks pretty good. Done with initial review. |
|
@redmunds fixes done. I'm going to start on unit tests now (but feel free to merge this pull if you think it's done -- I'll submit the unit tests separately). |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Feb 28, 2013
move starting of static server to live dev start time and fix up some comments
This was referenced Sep 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2987 and #2988 by moving the starting of the static server to live dev start time. Also fixes up some comments that were out of sync with an API change.
Assinging to @redmunds
cc @njx
Should also really really fix #2981 (cc @gruehle )