-
Notifications
You must be signed in to change notification settings - Fork 7.6k
use Chinese punctuation,add new item for string.js #7306
Conversation
This commit contained Chinese punctuation for zh-cn locale all around, and added untranslated item from root folder. At the same time it unified words usage of the global scope, and corrected typos like 实施预览 => 实时预览 (for 'Live Preview')
@michaeljayt Thanks for catching incorrect translation. I just landed some translation to the same file. Can you merge from master and resolve the conflicts? |
Thanks but, well, I don't know how to do that..Is that means I need to merge from master repo first, then resolve the conflicts, and send another pull request at last? |
@michaeljayt Yes. Checkout to this branch first, then use |
Conflicts: src/nls/zh-cn/strings.js
@TomMalbran I made it, thanks for your instructions! |
I killed those duplicate strings, and this commit should be okay now... |
"NO_MODIFICATION_ALLOWED_ERR" : "无法修改此目录。", | ||
"NO_MODIFICATION_ALLOWED_ERR_FILE" : "你没有做出修改的权限。", | ||
"CONTENTS_MODIFIED_ERR" : "该文件已在 {APP_NAME} 外被修改。", | ||
"FILE_EXISTS_ERR" : "文件/目录名已存在。", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
@michaeljayt Thanks for your compliment on beautiful Chinese on some strings, but I didn't do any translation. They all come from community contributors like you. I noticed that you're touching lots of previous translation besides the punctuation characters. So don't expect me to get the review done soon, it will take me some time to do a thorough review of all the changes. I noticed that you also remove the comment on the very last line. Please put it back and update the SHA with the version of English strings.js you used for this pull request. For more info you can read Localization Readme. |
@RaymondLim What's the problem with the The Travis CI build system now? |
@michaeljayt We're aware of CLA check failure and someone will be looking into it soon. |
@michaeljayt Hey Michael, I don't suppose we should keep Chinese period 。inside double quotes " ". It looks weird with 。 |
@jasonnjit Got it, had you reviewed these sentences on the application interface? If weird, how should we deal with other punctuations like ,(the comma) and !(exclamation mark) ? |
Hi Michael, On Wed, Mar 26, 2014 at 7:55 PM, Michael J. notifications@github.comwrote:
All bests, |
@jasonnjit so how should I (or,other contributor like me) deal with this kind of issue? Anyone here to provide an standard for non-English punctuation, or I need to revert those punctuation? |
"NOT_FOUND_ERR" : "无法找到该文件。", | ||
"NOT_READABLE_ERR" : "无法读取该文件。", | ||
"NO_MODIFICATION_ALLOWED_ERR" : "无法修改此目录。", | ||
"NO_MODIFICATION_ALLOWED_ERR_FILE" : "你没有做出修改的权限。", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 你没有权限修改。
is better here instead of having 做出
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
Marking medium priority since this is a major update. |
Closing since we've already had newer pull request landed. |
This commit contained Chinese punctuation for zh-cn locale all around, and added untranslated item from root folder. At the same time it has unified words usage of the global scope, and corrected typos like 实施预览 => 实时预览 (for 'Live Preview')