New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in LocalizationExample #8828

Merged
merged 7 commits into from Aug 30, 2014

Conversation

Projects
None yet
5 participants
@Denisov21
Contributor

Denisov21 commented Aug 21, 2014

No description provided.

@Denisov21 Denisov21 changed the title from Create package.json to Update in LocalizationExample Aug 21, 2014

Show outdated Hide outdated src/extensions/samples/LocalizationExample/package.json
},
"i18n": [
"en",
"fr"

This comment has been minimized.

@peterflynn

peterflynn Aug 22, 2014

Member

Nit: these should be indented one more level, like the "engines" section above

@peterflynn

peterflynn Aug 22, 2014

Member

Nit: these should be indented one more level, like the "engines" section above

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Aug 22, 2014

Contributor

@peterflynn Done, you can merge!

Contributor

Denisov21 commented Aug 22, 2014

@peterflynn Done, you can merge!

@@ -48,6 +48,8 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a
* main.js – loads the Strings module for the plugin and uses mustache to localize html content
* package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]`
* strings.js – uses i18n to load a strings.js file in the nls folder
* htmlContent

This comment has been minimized.

@TomMalbran

TomMalbran Aug 22, 2014

Contributor

This was an error from before. But since you are editing this file, would you mind fixing the indentation here? This and the next line should be indented 4 more spaces. Thanks

@TomMalbran

TomMalbran Aug 22, 2014

Contributor

This was an error from before. But since you are editing this file, would you mind fixing the indentation here? This and the next line should be indented 4 more spaces. Thanks

@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Aug 23, 2014

Contributor

@TomMalbran Done!

Contributor

Denisov21 commented Aug 23, 2014

@TomMalbran Done!

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Aug 26, 2014

Contributor

@TomMalbran Can we merge this?

Contributor

ingorichter commented Aug 26, 2014

@TomMalbran Can we merge this?

Show outdated Hide outdated src/extensions/samples/LocalizationExample/README.md
* nls
* strings.js – configures i18n by specifying the root folder and listing the locales supported by the plugin
* root
* htmlContent

This comment has been minimized.

@TomMalbran

TomMalbran Aug 26, 2014

Contributor

This is still not quite right. It should be:

    * htmlContent
        * htmlfragment.html – html template to be localized by mustache
    * nls
        * strings.js – configures i18n by specifying the root folder  and listing the locales supported by the plugin
        * root
            * strings.js – contains the English strings
        * fr
            * strings.js – contains the French strings
        * etc. for each locale
@TomMalbran

TomMalbran Aug 26, 2014

Contributor

This is still not quite right. It should be:

    * htmlContent
        * htmlfragment.html – html template to be localized by mustache
    * nls
        * strings.js – configures i18n by specifying the root folder  and listing the locales supported by the plugin
        * root
            * strings.js – contains the English strings
        * fr
            * strings.js – contains the French strings
        * etc. for each locale

This comment has been minimized.

@ingorichter

ingorichter Aug 27, 2014

Contributor

Okay, then we'll take it for Release 44. Thanks.

@ingorichter

ingorichter Aug 27, 2014

Contributor

Okay, then we'll take it for Release 44. Thanks.

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Aug 26, 2014

Contributor

@ingorichter The folder list is still not quite right. That should be fixed. We can still merge it and fix it if you want it for the next release.

Contributor

TomMalbran commented Aug 26, 2014

@ingorichter The folder list is still not quite right. That should be fixed. We can still merge it and fix it if you want it for the next release.

@@ -48,17 +48,19 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a
* main.js – loads the Strings module for the plugin and uses mustache to localize html content
* package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]`

This comment has been minimized.

@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

We may point out that this step is optional.

@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

We may point out that this step is optional.

This comment has been minimized.

@TomMalbran

TomMalbran Aug 26, 2014

Contributor

Everything here is optional. But if you are adding translations, is better if you add this.

@TomMalbran

TomMalbran Aug 26, 2014

Contributor

Everything here is optional. But if you are adding translations, is better if you add this.

Show outdated Hide outdated src/extensions/samples/LocalizationExample/README.md
* htmlContent
* htmlfragment.html – html template to be localized by mustache
* nls
* strings.js – configures i18n by specifying the root folder and listing the locales supported by the plugin

This comment has been minimized.

@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

Nit: two spaces (before and)

@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

Nit: two spaces (before and)

Show outdated Hide outdated src/extensions/samples/LocalizationExample/package.json
"description": "LocalizationExample.",
"homepage": "https://github.com/adobe/brackets/tree/master/src/extensions/samples/LocalizationExample",
"version": "1.0.0",
"author": "",

This comment has been minimized.

@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

I'd update the metadata to something more usual, like (without the comments):

{
    "title": "Localization Example", // include a space to show the title can include spaces
    "description": "A guide on how to localize your extension.",
    "author": "The Brackets team"
}
@MarcelGerber

MarcelGerber Aug 26, 2014

Contributor

I'd update the metadata to something more usual, like (without the comments):

{
    "title": "Localization Example", // include a space to show the title can include spaces
    "description": "A guide on how to localize your extension.",
    "author": "The Brackets team"
}
@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Aug 29, 2014

Contributor

Hi @ingorichter, I made the changes suggested by @MarcelGerber

Contributor

Denisov21 commented Aug 29, 2014

Hi @ingorichter, I made the changes suggested by @MarcelGerber

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Aug 30, 2014

Contributor

The README is still not quite right (see the parsed version). Just copy and paste the markdown:

* htmlContent
    * htmlfragment.html – html template to be localized by mustache
* nls
    * strings.js – configures i18n by specifying the  root folder and listing the locales supported by the plugin
    * root
        * strings.js – contains the English strings
    * fr
        * strings.js – contains the French strings
    * etc. for each locale
Contributor

MarcelGerber commented Aug 30, 2014

The README is still not quite right (see the parsed version). Just copy and paste the markdown:

* htmlContent
    * htmlfragment.html – html template to be localized by mustache
* nls
    * strings.js – configures i18n by specifying the  root folder and listing the locales supported by the plugin
    * root
        * strings.js – contains the English strings
    * fr
        * strings.js – contains the French strings
    * etc. for each locale
@Denisov21

This comment has been minimized.

Show comment
Hide comment
@Denisov21

Denisov21 Aug 30, 2014

Contributor

Hi @MarcelGerber, Ready for a final check! Sorry for the error.

Contributor

Denisov21 commented Aug 30, 2014

Hi @MarcelGerber, Ready for a final check! Sorry for the error.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Aug 30, 2014

Contributor

Looks good. (But I can't merge, so let's wait for @TomMalbran)

Contributor

MarcelGerber commented Aug 30, 2014

Looks good. (But I can't merge, so let's wait for @TomMalbran)

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Aug 30, 2014

Contributor

It looks good to me too. Lets merge it :)

Contributor

TomMalbran commented Aug 30, 2014

It looks good to me too. Lets merge it :)

TomMalbran added a commit that referenced this pull request Aug 30, 2014

Merge pull request #8828 from Denisov21/patch-18
Update in LocalizationExample

@TomMalbran TomMalbran merged commit 771c3e3 into adobe:master Aug 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment