Update in LocalizationExample #8828
Conversation
| }, | ||
| "i18n": [ | ||
| "en", | ||
| "fr" |
There was a problem hiding this comment.
Nit: these should be indented one more level, like the "engines" section above
|
@peterflynn Done, you can merge! |
| @@ -48,6 +48,8 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a | |||
|
|
|||
| * main.js – loads the Strings module for the plugin and uses mustache to localize html content | |||
|
|
|||
| * package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]` | |||
|
|
|||
| * strings.js – uses i18n to load a strings.js file in the nls folder | |||
|
|
|||
| * htmlContent | |||
There was a problem hiding this comment.
This was an error from before. But since you are editing this file, would you mind fixing the indentation here? This and the next line should be indented 4 more spaces. Thanks
|
@TomMalbran Done! |
|
@TomMalbran Can we merge this? |
| * nls | ||
| * strings.js – configures i18n by specifying the root folder and listing the locales supported by the plugin | ||
| * root | ||
| * htmlContent |
There was a problem hiding this comment.
This is still not quite right. It should be:
* htmlContent
* htmlfragment.html – html template to be localized by mustache
* nls
* strings.js – configures i18n by specifying the root folder and listing the locales supported by the plugin
* root
* strings.js – contains the English strings
* fr
* strings.js – contains the French strings
* etc. for each locale
There was a problem hiding this comment.
Okay, then we'll take it for Release 44. Thanks.
|
@ingorichter The folder list is still not quite right. That should be fixed. We can still merge it and fix it if you want it for the next release. |
| @@ -48,17 +48,19 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a | |||
|
|
|||
| * main.js – loads the Strings module for the plugin and uses mustache to localize html content | |||
|
|
|||
| * package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]` | |||
There was a problem hiding this comment.
We may point out that this step is optional.
There was a problem hiding this comment.
Everything here is optional. But if you are adding translations, is better if you add this.
|
Hi @ingorichter, I made the changes suggested by @marcelgerber |
|
The README is still not quite right (see the parsed version). Just copy and paste the markdown: * htmlContent
* htmlfragment.html – html template to be localized by mustache
* nls
* strings.js – configures i18n by specifying the root folder and listing the locales supported by the plugin
* root
* strings.js – contains the English strings
* fr
* strings.js – contains the French strings
* etc. for each locale |
|
Hi @marcelgerber, Ready for a final check! Sorry for the error. |
|
Looks good. (But I can't merge, so let's wait for @TomMalbran) |
|
It looks good to me too. Lets merge it :) |
Update in LocalizationExample
No description provided.