Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update in LocalizationExample #8828

Merged
merged 7 commits into from
Aug 30, 2014
Merged

Update in LocalizationExample #8828

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbcec9e
Create package.json
Aug 21, 2014
5c0fd1b
Update README.md
Aug 21, 2014
e966879
Update package.json
Aug 22, 2014
baa6ad5
Update README.md
Aug 23, 2014
c0ca4d1
Update README.md
Aug 28, 2014
dbcbbd9
Update package.json
Aug 28, 2014
f122452
Update README.md
Aug 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/extensions/samples/LocalizationExample/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ Move this plugin to the extensions\user\ folder to run the plugin. It will add a

* main.js – loads the Strings module for the plugin and uses mustache to localize html content

* package.json - add the translation languages as in the example: `"i18n: ["en", "fr" ]`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may point out that this step is optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here is optional. But if you are adding translations, is better if you add this.


* strings.js – uses i18n to load a strings.js file in the nls folder

* htmlContent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an error from before. But since you are editing this file, would you mind fixing the indentation here? This and the next line should be indented 4 more spaces. Thanks

Expand Down
16 changes: 16 additions & 0 deletions src/extensions/samples/LocalizationExample/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "localization-example",
"title": "LocalizationExample",
"description": "LocalizationExample.",
"homepage": "https://github.com/adobe/brackets/tree/master/src/extensions/samples/LocalizationExample",
"version": "1.0.0",
"author": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update the metadata to something more usual, like (without the comments):

{
    "title": "Localization Example", // include a space to show the title can include spaces
    "description": "A guide on how to localize your extension.",
    "author": "The Brackets team"
}

"license": "MIT",
"engines": {
"brackets": ">=0.42.0"
},
"i18n": [
"en",
"fr"
]
}