* ci: add make_unique rule to check_format

Signed-off-by: Yuchen Dai <silentdai@gmail.com>

Add an http filter to extract the original source on a per-http-request basis

Signed-off-by: Kyle Larose <kyle@agilicus.com>

Signed-off-by: Elisha Ziskind <eziskind@google.com>

…or in libstdc+++ (envoyproxy#7099)

With libstdc++ the the std::tuple constructor picked by a {x,y,z} parameter is "explicit tuple(TP_&&...) ", which causes a compilation error, remove the usage of std::tuple to make the test code more compatible w/ libstdc++.

Risk Level: LOW
Testing: Unit test.

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

…y#7081)

Certain clusters have cluster specific load balancers. This change
allows a cluster to explicitly provide one, both allowing extension
clusters to easily provide a dedicated load balancer, as well as
allowing for future cleanup of the original DST LB configuration.

This change is needed for Redis Cluster as well as
envoyproxy#1606.

Risk Level: Low
Testing: New UTs and integration tests.

Signed-off-by: Matt Klein <mklein@lyft.com>

)

Bring back the v1 original_dst that is available in cds_json.cc (translateCluster, original_dst clusters must have no hosts configured) to v2.

Bonus: convert most of the v1 json config to v2, will remove the last two when we do translateCluster sweeping, cc @derekargueta.

Risk Level: Low
Testing: Unit tests

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>

…#7102)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>

To support TDS and to provide operator flexibility in how it relates to
existing runtime layering, this PR introduces support for explicit
control over layering. This eliminates the distinguished role of
subdirectory and override_subdirectory, for example, in favor of
arbitrary disk overlay layers.

This PR deprecates the existing runtime configuration in favor of the
new layered variant.

As a bonus, the PR fixes some of the runtime stats and related docs.

Risk level: Low
Testing: various unit tests (including server_test) additions.

Part of envoyproxy#6708.

Signed-off-by: Harvey Tuch <htuch@google.com>

Filter through headers to add and remove in the header parser fuzzer.

Risk level: Low
Testing: Added corpus entry with null characters in headers to add.

Signed-off-by: Asra Ali <asraa@google.com>

…nvoyproxy#7093)

Fixing a bug where if pausing with StopIterationNoBuffer, continuing with fin-only payload wouldn't result in the filter chain continuing.

Risk Level: High (tweak to the HCM)
Testing: new integration test
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: Sumukh Shivaprakash <sumukhs@microsoft.com>

…yproxy#6913)

This patch changed sendLocalReply to send GrpcMessage in percent-encoded
instead of plain string.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>

This PR provides the TDS API config. The implementation and docs will be
added in a followup, the idea is to unblock some projects that depend on
the details here.

Risk level: Low
Testing: @envoy_api build

Part of envoyproxy#6708

Signed-off-by: Harvey Tuch <htuch@google.com>

Risk Level: LOW
Testing: code move only.

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

Enforce Harvey to review any API changes.

Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>

Signed-off-by: Dan Zhang <danzh@google.com>

…voyproxy#7063)

* Add InlineStorage mixin supplying the allocation overrides needed to make it easier to create variable-size structures.

Signed-off-by: Joshua Marantz <jmarantz@google.com>

Migration from the build recipes to foreign_cc rules resulted
in dependencies being built with different compiler flags.

Among other things, those compiler flags were added:

    -ffunction-sections -fdata-sections

use of which leads to LuaJIT panicking:

    PANIC: unprotected error in call to Lua API

and Envoy subsequently crashing.

Broken in envoyproxy#6168.

Fixes istio/istio#13722.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Description: When multiple test validations are mentioned in the `validation` section, 
eg: 
```
"validate": {
        "host_rewrite": "api.lyft.com",
        "virtual_host_name": "api",
        "path_rewrite": "/pre/test",
        "cluster_name": "www2"
      }
```
`finalizeRequestHeaders` is called multiple times causing ASSERT failures. None of the existing tests covered this scenario. Now few tests have been added to simulate the error.

Before the fix the failure looked like this
```
[2019-05-29 19:47:48.210][1405009][critical][assert] [source/common/router/config_impl.cc:557] assert failure: case_sensitive_ ? absl::StartsWith(path, matched_path) : absl::StartsWithIgnoreCase(path, matched_path).
```

Risk Level: Low
Testing: 
 - Added breaking tests and fixed them using the fix.
 - Tested the tool against lyft's routes

Signed-off-by: Jyoti Mahapatra <jmahapatra@lyft.com>

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Followup to envoyproxy#7114.

Signed-off-by: Harvey Tuch <htuch@google.com>

…nvoyproxy#7019)

Signed-off-by: Mike Grass <mgrass@salesforce.com>

Signed-off-by: Joshua Marantz <jmarantz@google.com>

This PR also fully deprecates the tcp_proxy v1 configuration.
This will be deleted following the standard deprecation cycle.
All new uses should use filter chain matching.

Fixes envoyproxy#4457

Signed-off-by: Matt Klein <mklein@lyft.com>

…oxy#7110)

Delta services other than DeltaClusters were missing. Also added those services to proto_descriptors.cc. Also added some other things that proto_descriptors.cc was missing. envoyproxy#4991

Risk Level: low

Signed-off-by: Fred Douglas <fredlas@google.com>

…#7115)

They include fixes for future Bazel changes. In particular, the
repository can now build with --incompatible_depset_is_not_iterable,
which will be included in Bazel 0.27.

Description:
Risk Level: low
Testing: bazel build --nobuild ... --incompatible_depset_is_not_iterable

envoyproxy#6995

Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>

…proxy#7098)

I copied @oquenchil's changes from envoyproxy#6968 (comment) and fixed the python formatting errors. This let us link our exe w/ the new flag default (--incompatible_do_not_split_linking_cmdline) and with the old value. When Envoy upgrades to bazel 0.27 we should remove the old functions in this file.

Risk Level: Low
Testing: Ran bazel test --incompatible_do_not_split_linking_cmdline //test/exe/... and bazel test //test/exe/...
Docs Changes: N/A
Release Notes: N/A

Fixes envoyproxy#6968

Signed-off-by: Frank Fort <ffort@google.com>

Remove duplicated words in sentences and fix some typos caught by linter.

Risk Level: LOW
Testing: doc only changes.
Docs Changes: N/A

Signed-off-by: Xin Zhuang <stevenzzz@google.com>

Fix a time conversion signed int overflow (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11852).

Risk Level: low
Testing: fuzz

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>

This is the plumbing to support envoyproxy#6651 and envoyproxy#6818, where we remove the global control over message
validation type and put it under the control of a new injectable interface. It's pretty horrible
IMHO that there is this much churn; the closest major context object that we could associate with is
Api.

The main from the new dependency is that we can:

1. Inject different validators, e.g. one for static config when ingesting bootstrap resources, another for xDS.
2. Validation state, so that we can reach back to the server stats for the purpose of tracking unknown fields.
This PR introduces a visitor pattern for the validator and starts to do the threading needed for dependency injection here.

It's possible that we could extend this visitor for deprecated fields in the future to provide finer grained control over these alongside unknown, if there is a use case.

No new behavior should be added in this PR.

Risk level: Low.
Testing: bazel test //test/...

Signed-off-by: Harvey Tuch <htuch@google.com>

Fixes a local -Wmissing-braces warning

Risk Level: n/a (test only)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Fully-qualify the expanded portions of stats macros for use in external callsites.

Risk Level: Low.

Signed-off-by: James Buckland <jbuckland@google.com>

Fixes a typo from envoyproxy#7072.

Risk Level: Low

Signed-off-by: James Buckland <jbuckland@google.com>

…yproxy#6920)

Description:

//test/extensions/quic_listeners/quiche/platform:quic_platform_test and @com_googlesource_quiche//:epoll_server_test depends on (linux specific) epoll APIs, which causes compilation errors on non-linux platforms, e.g. envoyproxy#6896.

This PR makes them no-op on non-linux platforms.

Risk Level: none, test only.
Testing:

bazel test --test_output=all test/extensions/quic_listeners/quiche/platform:all @com_googlesource_quiche//:all

Docs Changes: none
Release Notes: none
Fixes envoyproxy#6896

Signed-off-by: Bin Wu <wub@google.com>

Description:
Upgrade Bazel to 0.26 along with build fixes.

Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

…7127)

* Remove the regex used for determining the merge-mode for gauges; they are all specified when creating gauges now. Also cleans up some method docs.

Signed-off-by: Joshua Marantz <jmarantz@google.com>

…#7103)

Signed-off-by: Elisha Ziskind <eziskind@google.com>

…oyproxy#7122)

The Subscription interface was receiving its callbacks in start(). No usage actually needed the ability to defer providing callbacks until after construction. Furthermore, some Subscription implementations want to hold onto the callbacks, and had to use a pointer rather than a reference.

Risk Level: low

Signed-off-by: Fred Douglas <fredlas@google.com>

Risk Level: low
Testing: added to unit test

Signed-off-by: Fred Douglas <fredlas@google.com>

Signed-off-by: Derek Argueta <dereka@pinterest.com>

Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>

envoyproxy#7068)

Integrate the Scoped Route Discovery Service (SRDS) API into the HttpConnectionManager.

NOTES:

- This is the last PR in the chain originating from parent envoyproxy#5839.
- The scoped routing logic which can be configured through this API has not yet been implemented; it will be done in follow up PRs.

Risk Level: Low (API is not yet fully implemented and should not be enabled)
Testing: Integration tests added.

Signed-off-by: Andres Guedez <aguedez@google.com>

…mInfo and add mock (envoyproxy#7155)

Initializes downstreamSslConnectionInfo pointer in TestStreamInfo and adds a mock object for it in fuzzers.
Fixes crash in:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15066

Risk Level: Low
Testing: Add a corpus entry with downstream info.

Signed-off-by: Asra Ali <asraa@google.com>

envoyproxy#7092)

Previously, constant strings like "envoy.api.v2.EndpointDiscoveryService.FetchEndpoints" were all over eds.cc, rds_impl.cc, etc, being fed into SubscriptionFactory. Now, they are all centralized in SubscriptionFactory, the only place that actually uses them. envoyproxy#4991

Risk Level: low

Signed-off-by: Fred Douglas <fredlas@google.com>

…rward (envoyproxy#6893)

 Implement three new router behaviors, append_cluster, append_upstream_host and do_not_forward. These are enabled via the new StreamDebugInfo class, although no API is provided to set them.
Risk Level: low/medium (changes to router)

Testing: added unit tests for behaviors separately and combined.
Docs Changes: n/a
Release Notes: n/a (I think...)

Fixes: envoyproxy#6453

Signed-off-by: Dan Rosen <mergeconflict@google.com>

Signed-off-by: Derek Argueta <dereka@pinterest.com>

With this update, Envoy is compatible with the upcoming Bazel 0.27.

Signed-off-by: Laurent Le Brun <laurentlb@gmail.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

…n_manager_utility.cc

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>

Signed-off-by: trifan <trifan@adobe.com>