Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Return last modified date of a file in a header #233

Closed
dominique-pfister opened this issue Dec 15, 2020 · 4 comments · Fixed by #235
Closed

Return last modified date of a file in a header #233

dominique-pfister opened this issue Dec 15, 2020 · 4 comments · Fixed by #235
Labels
enhancement New feature or request released

Comments

@dominique-pfister
Copy link
Contributor

In order to detect changes to a file, it would be helpful if data-embed would return the last modified date of that file, e.g. in the Last-Modified HTTP response header.

This feature would particularly help in solving adobe/theblog#550

@trieloff
Copy link
Contributor

Sounds reasonable.

@tripodsan
Copy link
Contributor

doesn't getWorkbook() return the last modified date?
https://github.com/adobe/helix-data-embed/blob/master/src/matchers/excel.js#L31

@dominique-pfister
Copy link
Contributor Author

doesn't getWorkbook() return the last modified date?
https://github.com/adobe/helix-data-embed/blob/master/src/matchers/excel.js#L31

I don't think so: getWorkbook() just creates an instance of Workbook, adding a reference to OneDrive and the coordinates of the workbook:
https://github.com/adobe/helix-onedrive-support/blob/master/src/Workbook.js#L21-L27

@trieloff
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants