fix: improve comments cleanup logic #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaack
approved these changes
Jan 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
## [3.1.4](v3.1.3...v3.1.4) (2024-01-17) ### Bug Fixes * import comments cleanup logic ([#290](#290)) ([deec675](deec675))
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While importing https://news.sap.com/2023/03/sap-cx-intelligent-industry-tailored-solutions/, @mhaack found a weird behaviour: content gets stripped out.
Root cause: page contains a
ds-contextual-navigationweb component with attributelast-visited-country="" <!--="". Of course attribute value breaks the comments cleanup logic (string regex based).PR improves the regex and cleanup logic, even though I am not sure removing comments still matter now we are using a DOM element everywhere.