Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Support Twitter embeds #700

Closed
kptdobe opened this issue May 6, 2020 · 4 comments
Closed

Support Twitter embeds #700

kptdobe opened this issue May 6, 2020 · 4 comments
Labels
released

Comments

@kptdobe
Copy link
Contributor

kptdobe commented May 6, 2020

See https://theblog.adobe.com/the-best-of-summit-2020-so-far/.

Required for adobe/theblog#186
@trieloff trieloff changed the title Support Tweeter embeds Support Twitter embeds May 6, 2020
@trieloff
Copy link
Contributor

trieloff commented May 6, 2020

@kptdobe you had me worried that you've found a new Social Media service that I wasn't aware of.

@trieloff
Copy link
Contributor

trieloff commented May 6, 2020

Works for helix-embed, needs whitelist adjustment in helix-pipeline: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://twitter.com/iSocialFanz/status/1245029509524586505?ref_src=twsrc%5Etfw%7Ctwcamp%5Etweetembed%7Ctwterm%5E1245029509524586505&ref_url=https%3A%2F%2Ftheblog.adobe.com%2Fthe-best-of-summit-2020-so-far%2F

@trieloff trieloff transferred this issue from adobe/helix-embed May 6, 2020
@kptdobe
Copy link
Contributor Author

kptdobe commented May 6, 2020

oh yeah, this would have been pretty unexpected ;)

Good point, I did not check if this is already supported :)
At least, no fully.

@trieloff trieloff mentioned this issue May 6, 2020
Merged
@MarquiseRosier MarquiseRosier mentioned this issue May 6, 2020
Closed
adobe-bot pushed a commit that referenced this issue May 13, 2020
@semantic-release-bot
chore(release): 7.1.0 [skip ci]
9c751a9 
# [7.1.0](v7.0.4...v7.1.0) (2020-05-13)

### Features

* **embed:** whitelist instagram.com ([96d816c](96d816c)), closes [#701](#701)
* **embed:** whitelist spotify ([8706500](8706500))
* **embed:** whitelist spotify ([9d73286](9d73286))
* **embed:** whitelist twitter.com ([4b7e2a3](4b7e2a3)), closes [#700](#700)
* **embed:** whitelist vimeo.com ([1b32812](1b32812)), closes [#702](#702)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trieloff @kptdobe @adobe-bot