-
Notifications
You must be signed in to change notification settings - Fork 19
Support Vimeo embeds #702
Comments
Works for Needs whitelisting in |
I think that's a general issue, it seems that you can export the video and only get the player url. For Soundcloud, I had the same issue that I solved by requesting the player url and extract the direct url from the dom meta (see https://github.com/adobe/helix-theblog-importer/blob/master/src/index.js#L44-L64) Video does not provide the "direct" url. See https://player.vimeo.com/video/349091463 One option would be to keep the player url and |
I created a private video (only visible for people who have the URL), copied the URL in Vimeo and it still works: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://vimeo.com/415498678/5349aa3e1f – so for private videos I think authors will be able to still share and embed them. |
For the import, it is more the other way around: we only have the player url, I can use it for the embed but then it does not work: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://player.vimeo.com/video/349091463 |
My proposal is to make helix-embed smarter and use the player url as is if this is the one provided. |
@kptdobe This is on the list, just needs whitelisting me thinks :) |
# [7.1.0](v7.0.4...v7.1.0) (2020-05-13) ### Features * **embed:** whitelist instagram.com ([96d816c](96d816c)), closes [#701](#701) * **embed:** whitelist spotify ([8706500](8706500)) * **embed:** whitelist spotify ([9d73286](9d73286)) * **embed:** whitelist twitter.com ([4b7e2a3](4b7e2a3)), closes [#700](#700) * **embed:** whitelist vimeo.com ([1b32812](1b32812)), closes [#702](#702)
🎉 This issue has been resolved in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See https://theblog.adobe.com/slow-down-and-speed-up-clips-in-premiere-rush/.
Required for adobe/theblog#186
The text was updated successfully, but these errors were encountered: