Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Support Vimeo embeds #702

Closed
kptdobe opened this issue May 6, 2020 · 7 comments
Closed

Support Vimeo embeds #702

kptdobe opened this issue May 6, 2020 · 7 comments
Labels

Comments

@kptdobe
Copy link
Contributor

kptdobe commented May 6, 2020

See https://theblog.adobe.com/slow-down-and-speed-up-clips-in-premiere-rush/.

Required for adobe/theblog#186

@trieloff
Copy link
Contributor

trieloff commented May 6, 2020

Works for helix-embed: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://vimeo.com/253539791 (I couldn't find the exact video URLs)

Needs whitelisting in helix-pipeline

@trieloff trieloff transferred this issue from adobe/helix-embed May 6, 2020
@kptdobe
Copy link
Contributor Author

kptdobe commented May 6, 2020

I couldn't find the exact video URLs

I think that's a general issue, it seems that you can export the video and only get the player url. For Soundcloud, I had the same issue that I solved by requesting the player url and extract the direct url from the dom meta (see https://github.com/adobe/helix-theblog-importer/blob/master/src/index.js#L44-L64)

Video does not provide the "direct" url. See https://player.vimeo.com/video/349091463
I even cannot find the video from the search engine, there might be an option to not make it accessible except via the player.

One option would be to keep the player url and helix-embed would be able to deal with it.
WDYT ?

@trieloff
Copy link
Contributor

trieloff commented May 6, 2020

I created a private video (only visible for people who have the URL), copied the URL in Vimeo and it still works: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://vimeo.com/415498678/5349aa3e1f – so for private videos I think authors will be able to still share and embed them.

@kptdobe
Copy link
Contributor Author

kptdobe commented May 6, 2020

For the import, it is more the other way around: we only have the player url, I can use it for the embed but then it does not work: https://adobeioruntime.net/api/v1/web/helix/helix-services/embed@v1/https://player.vimeo.com/video/349091463

@kptdobe
Copy link
Contributor Author

kptdobe commented May 6, 2020

My proposal is to make helix-embed smarter and use the player url as is if this is the one provided.

@MarquiseRosier
Copy link
Contributor

MarquiseRosier commented May 6, 2020

@kptdobe
{
"s": "^https?:\/\/player\.vimeo\.com\/video\/(\d+)",
"m": "i"
},

This is on the list, just needs whitelisting me thinks :)

adobe-bot pushed a commit that referenced this issue May 13, 2020
# [7.1.0](v7.0.4...v7.1.0) (2020-05-13)

### Features

* **embed:** whitelist instagram.com ([96d816c](96d816c)), closes [#701](#701)
* **embed:** whitelist spotify ([8706500](8706500))
* **embed:** whitelist spotify ([9d73286](9d73286))
* **embed:** whitelist twitter.com ([4b7e2a3](4b7e2a3)), closes [#700](#700)
* **embed:** whitelist vimeo.com ([1b32812](1b32812)), closes [#702](#702)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants