-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
… into triple-embed-threat
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 1459 1459
=========================================
Hits 1459 1459 Continue to review full report at Codecov.
|
This PR will trigger a minor release when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok even if it does not fully solve the Vimeo + player case (see comment in #702) (more will be required)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add Spotify as well?
I think we should just get the list from IFramely so that we don't run into the issue of not supporting embeds, unless it's something we really don't support yet @trieloff we can just fetch this resource: http://iframe.ly/domains.json |
I think using the iFramely whitelist is a good idea for helix pages. Let’s open another issue for that. |
Ok! :) |
9d73286
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fix for #700 #701 and #702
For adobe/theblog#186